Skip to content

fix: require complete policy for new public TypedDicts - #4900

Merged
seratch merged 1 commit into
mainfrom
fix/freeze-public-typed-dict-fields
Sep 7, 2026
Merged

fix: require complete policy for new public TypedDicts#4900
seratch merged 1 commit into
mainfrom
fix/freeze-public-typed-dict-fields

Conversation

@seratch

@seratch seratch commented Sep 7, 2026

Copy link
Copy Markdown
Member

This pull request fixes missing field coverage for WebSearchToolImageSettings and makes the existing prospective contract CI job reject incomplete policy registration on implementation PRs.

It registers the optional max_results: int and caption: bool fields and requires every newly exported top-level TypedDict to have complete field coverage. Previously released exports retain their curated coverage.

Addresses the TypedDict coverage review comment in #4576.

@seratch seratch added this to the 0.22.x milestone Sep 7, 2026
@seratch seratch added the project label Sep 7, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T15:48:38.804422Z ceec081 PR opened
🔒 Security Review Completed 2026-09-07T15:49:31.251275Z ceec081 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@seratch seratch changed the title fix: Require complete policy for new public TypedDicts fix: require complete policy for new public TypedDicts Sep 7, 2026
@seratch
seratch enabled auto-merge (squash) September 7, 2026 15:51
@seratch
seratch merged commit d3761b3 into main Sep 7, 2026
18 checks passed
@seratch
seratch deleted the fix/freeze-public-typed-dict-fields branch September 7, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant