Repository navigation
chore(api): align initial policy-pin review with active main - #1271
Conversation
Castiron-Internal-PR: openai/openai-java-internal#353 Castiron-Source-SHA: 06c06f7838e3933041d005627dccbaeb11914cd7 Castiron-Public-Base-SHA: d865378
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 0 mixed files remain; 0 existing customizations changed. Compared A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 39893945856 --repo openai/openai-java \
--name castiron-custom-code-39893945856-1 --dir /tmp/castiron-custom-code-39893945856-1
git apply --stat /tmp/castiron-custom-code-39893945856-1/custom-code.patch
cat /tmp/castiron-custom-code-39893945856-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin d8653786396518d29eaeb9ec112d5209ed148489 51ba8fae02773e2bd11b899dfccb8b0861157d54
python3 scripts/castiron/custom_code_report.py report \
--base d8653786396518d29eaeb9ec112d5209ed148489 \
--head 51ba8fae02773e2bd11b899dfccb8b0861157d54 --target-branch main --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-51ba8fae0277
cat /tmp/castiron-custom-code-51ba8fae0277/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
|
Prerequisite for #1268: keeps the generated policy/workflow updates separate from the Decisions SDK changes. During initial Validation: strict generated-ownership verification passed; 231 policy tests ran (1 skipped). No SDK models or API schema/config changed. |
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed the Java policy source at 51ba8fae02773e2bd11b899dfccb8b0861157d54. Reviewed initial next-policy adoption and review-change invalidation. Both now compare the proposed effective policy with authenticated main during bootstrap; existing pins still compare with the protected target. Rollbacks, budget increases and mode changes retain exact-head human approval checks. The regression cases cover PR and queue selection plus invalidation after main advances. No actionable source finding.
Static source review only; I did not run candidate code, tests, or builds.
This automated source review is not human policy approval. Existing Java #1268 feedback remains unchanged.
Current hosted checks report success or skipped.
Summary
Use the active authenticated main policy when evaluating the initial next policy pin.
Changes