Repository navigation
test(helpers): cover prompt-cache TTL output contracts - #3009
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 0 mixed files remain; 0 existing customizations changed. Compared A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 40355579001 --repo openai/openai-node \
--name castiron-custom-code-40355579001-1 --dir /tmp/castiron-custom-code-40355579001-1
git apply --stat /tmp/castiron-custom-code-40355579001-1/custom-code.patch
cat /tmp/castiron-custom-code-40355579001-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin ac0867f7ecfab8afbc249b14c75d9df6f9a1d943 5efdd6d65525524fc631a54e71f9ab8d73f348b0
python3 scripts/castiron/custom_code_report.py report \
--base ac0867f7ecfab8afbc249b14c75d9df6f9a1d943 \
--head 5efdd6d65525524fc631a54e71f9ab8d73f348b0 --target-branch main --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-5efdd6d65525
cat /tmp/castiron-custom-code-5efdd6d65525/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45348aba8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed the source at 45348ab. The handwritten browser and supplied-output helpers now retain valid 30m and 12h TTL values in detached breakpoint snapshots. Invalid metadata still fails before output registration, and the added regressions cover wire values and later caller mutation. I found no new issues in this runtime change.
The generated public breakpoint types still omit TTL; this approval does not claim that the separate generated-type gap is fixed. I did not run local tests or builds.
Current-head hosted checks include passing Node 22, 24, and 26 tests, lint, builds, the custom-code budget, and OkTest.
Public #3029 already landed the generated
30m/12hprompt-cache TTL declarations and the handwritten Responses/browser validators. This PR now adds the remaining regression coverage on top of currentmain.The tests cover inline text/image/file blocks passed through the public
ResponsesRunnerTurn.supplyOutputssignature without payload casts; omitted TTLs; detached breakpoint snapshots after caller mutation; screenshot TTLs reaching a serialized Responses request; and rejection of invalid TTLs/accessors before pending calls are consumed. No generated declarations or runtime implementations differ frommain.Validation:
tsc --noEmit --module preserve), repository lint, and build pass.