Repository navigation
fix(docs): handle errors and early closes in WebSocket examples - #3056
markstuart-oai wants to merge 1 commit into
Conversation
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 0 mixed files remain; 0 existing customizations changed. Compared A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 40428185526 --repo openai/openai-node \
--name castiron-custom-code-40428185526-1 --dir /tmp/castiron-custom-code-40428185526-1
git apply --stat /tmp/castiron-custom-code-40428185526-1/custom-code.patch
cat /tmp/castiron-custom-code-40428185526-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 381709f60ae0a460d53d795f23c7eba7f576798e 74e0a679fb8d2e4f437228ecc11cbaa5a558b20a
python3 scripts/castiron/custom_code_report.py report \
--base 381709f60ae0a460d53d795f23c7eba7f576798e \
--head 74e0a679fb8d2e4f437228ecc11cbaa5a558b20a --target-branch main --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-74e0a679fb8d
cat /tmp/castiron-custom-code-74e0a679fb8d/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
The Realtime and Responses examples exit with an error after a failed generation, a protocol error, or a close before completion. A 60-second deadline bounds waits for the server.
Verification
Ran 13 local WebSocket cases with the actual SDK source, including two 60-second waits with silent peers. The repository-pinned oxfmt 0.72.0 formatter passed with ultracite 7.11.1 and the repository configuration. The formatting change leaves the compiled JavaScript unchanged.