Repository navigation
fix(realtime): honor the selected WebSocket session target - #3059
markstuart-oai wants to merge 1 commit into
Conversation
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 0 mixed files remain; 0 existing customizations changed. Compared A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 40462475870 --repo openai/openai-node \
--name castiron-custom-code-40462475870-1 --dir /tmp/castiron-custom-code-40462475870-1
git apply --stat /tmp/castiron-custom-code-40462475870-1/custom-code.patch
cat /tmp/castiron-custom-code-40462475870-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 60224b376e25912bb1143007c81d2ecdc7a7434c 2a9c9c479c9b9b94c41abe91933f2d8922cdc708
python3 scripts/castiron/custom_code_report.py report \
--base 60224b376e25912bb1143007c81d2ecdc7a7434c \
--head 2a9c9c479c9b9b94c41abe91933f2d8922cdc708 --target-branch main --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-2a9c9c479c9b
cat /tmp/castiron-custom-code-2a9c9c479c9b/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a9c9c479c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| url.searchParams.delete('model'); | ||
| url.searchParams.delete('intent'); | ||
| url.searchParams.delete('call_id'); |
There was a problem hiding this comment.
When callers use openai/beta/realtime/ws or openai/beta/realtime/websocket with a base URL containing a stale selector, these deletions have no effect because those entrypoints use the separate builder in src/beta/realtime/internal-base.ts. For example, a beta callID connection with baseURL: 'https://example.com/v1?model=old' still sends both model=old and the selected call_id, so the same ambiguous-target bug remains on a public surface; apply the selector cleanup to the beta builder and include BetaWS/BetaNative in the regression coverage.
AGENTS.md reference: AGENTS.md:L52-L54
Useful? React with 👍 / 👎.
Summary
An explicit Realtime session target could inherit a conflicting
model,intentorcall_idfrom the client base URL. A transcription or sideband connection could therefore send both targets to the server.Clear inherited session selectors before adding the requested one. Preserve other query parameters and the custom URL builder contract.
Verification
All 390 tests in eight focused repository suites passed, as did the full formatter. Across Chromium, Node 22, Node 24 and Bun, 48 accepted loopback handshakes carried exactly one target. The browser also rejected a long-lived synthetic key.