Skip to content

docs: carry generated-file ownership guidance to next - #3064

Merged
jbeckwith-oai merged 3 commits into
nextfrom
codex/node-next-generated-guidance
Oct 27, 2026
Merged

jbeckwith-oai merged 3 commits into
nextfrom
codex/node-next-generated-guidance

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Bring the reviewed contributor and security guidance from #3061 onto next before its first regeneration with the simplified compiler. Generated files are replaced; SDK-specific handwritten behavior belongs in separate helpers. The retired customization budget and reporter are no longer part of the contributor workflow.

Only AGENTS.md, .github/CONTRIBUTING.md, and docs/architecture/security-model.md change. The guidance is based on merged main e7afc14, with explicit transition wording for next: legacy workflow files and their publisher trust boundaries remain in scope until canonical regeneration removes them. Generated tooling removal will come through canonical generation separately.

Validation

Basic review, comparison with reviewed main and inspection of the retained legacy workflow boundaries, changed-file scope check, and git diff --check passed. No runtime, workflow, generation metadata, inventory, dependency, release, or branch-protection changes.

@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 27, 2026 18:50
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T19:08:57.515696Z d2eb40d Manual request
🔒 Security Review ✅ Completed 2026-10-27T19:09:12.771952Z d2eb40d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 98caa435dd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/architecture/security-model.md Outdated
@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 27, 2026
@jbeckwith-oai
jbeckwith-oai removed this pull request from the merge queue due to a manual request Oct 27, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf8fdc62ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/CONTRIBUTING.md
@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 27, 2026
@jbeckwith-oai

Copy link
Copy Markdown
Contributor Author

@codex review

@codex security review

Please review current head d2eb40d. Both prior findings are fixed and resolved after push; the summary still identifies the previous head.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d2eb40de49

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/CONTRIBUTING.md
@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: d2eb40de49

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Merged via the queue into next with commit 7dfc3dc Oct 27, 2026
31 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the codex/node-next-generated-guidance branch October 27, 2026 19:12
github-merge-queue Bot pushed a commit that referenced this pull request Oct 27, 2026
Addresses the late review finding on #3064: the next branch still
retains its strict ownership checker until canonical regeneration
removes the legacy tooling. Qualify the future guidance in AGENTS,
CONTRIBUTING, and the security model, and correct dependency-policy
citations. No checks or runtime behavior change.

Validation: basic code review, citation inspection, and git diff --check
passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants