Skip to content

ci: remove duplicate HTTPX2 test job - #4172

Draft
dpiet-oai wants to merge 1 commit into
mainfrom
codex/project-fast-ci-01-python-httpx2-ci
Draft

dpiet-oai wants to merge 1 commit into
mainfrom
codex/project-fast-ci-01-python-httpx2-ci

Conversation

@dpiet-oai

Copy link
Copy Markdown
Contributor

Changes being requested

Remove the dedicated test (HTTPX2) job and explicitly set OPENAI_TEST_HTTP_CLIENT=httpx2 on the retained Python test matrix. Both jobs used Python 3.14 and ran the same two Pydantic suites; the matrix continues to run both suites with the HTTPX2 transport. Update the provenance test's expected installer-job set without changing its assertions.

Before merge: coordinate with a repository administrator to remove the obsolete test (HTTPX2) required status from the active main ruleset, while retaining test (Python 3.14). Confirm the merge queue accepts the remaining required contexts.

Additional context & links

At base 43045fcaf91aec08571e54c57706597cefd32d45, the duplicate job took 187 seconds and finished before Python 3.14; this saves runner time, not 187 seconds of gate latency. Both jobs restored the same cache and reported identical Pydantic v2/v1 suite outcomes and installed dependency versions.

Validation: all four local collections (default/explicit HTTPX2 × Pydantic v2/v1) had the same 20,125 node IDs; five transport/provenance checks passed under each Pydantic version; Ruff, Python-version policy, and git diff --check passed.

@github-actions

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: 43045fcaf91aec08571e54c57706597cefd32d45.

Trusted main policy: 43045fcaf91aec08571e54c57706597cefd32d45.

✅ No new custom-code files detected.

0 mixed files remain; 0 existing customizations changed.

Compared 43045fcaf91a → 575e020cedc9. Generated baselines verified.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 40029275393 --repo openai/openai-python \
  --name castiron-custom-code-40029275393-1 --dir /tmp/castiron-custom-code-40029275393-1
git apply --stat /tmp/castiron-custom-code-40029275393-1/custom-code.patch
cat /tmp/castiron-custom-code-40029275393-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 43045fcaf91aec08571e54c57706597cefd32d45 575e020cedc94df0d114d413965fdcf823a3ffb5
python3 scripts/castiron/custom_code_report.py report \
  --base 43045fcaf91aec08571e54c57706597cefd32d45 \
  --head 575e020cedc94df0d114d413965fdcf823a3ffb5 --target-branch main --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-575e020cedc9
cat /tmp/castiron-custom-code-575e020cedc9/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@marcuswood-oai marcuswood-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 No changes requested.

Hosted Python 3.10/3.14 tests passed, with HTTPX2 and both Pydantic suites retained. The active ruleset still requires test (HTTPX2); the documented administrator update and merge-queue validation remain necessary before merge.


Reviewed: 575e020 · Base: 43045fc · sdk-pr-review

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 575e020cedc94df0d114d413965fdcf823a3ffb5. No blocking findings. The main Python matrix retains explicit HTTPX2 coverage and both Pydantic suites, so the separate job is redundant. Before merging, a repository administrator still needs to remove the obsolete test (HTTPX2) required status and verify the remaining merge-queue checks.

Source-only review; I did not run candidate code or tests. Hosted checks: 12 skipped, 21 success.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants