ci: allow 15 minutes for Ruby test jobs - #683
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 50 mixed files remain; 0 existing customizations changed. Compared 50 existing customizations unchanged
10 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 34245253284 --repo openai/openai-ruby \
--name castiron-custom-code-34245253284-1 --dir /tmp/castiron-custom-code-34245253284-1
git apply --stat /tmp/castiron-custom-code-34245253284-1/custom-code.patch
cat /tmp/castiron-custom-code-34245253284-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 21b8a70d48e2623e32aa01f95503adcf3fa2ba75 5e033fb491a29b93252aed1994835e900c428b5b
python3 scripts/castiron/custom_code_report.py report \
--base 21b8a70d48e2623e32aa01f95503adcf3fa2ba75 \
--head 5e033fb491a29b93252aed1994835e900c428b5b --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-5e033fb491a2
cat /tmp/castiron-custom-code-5e033fb491a2/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed the complete exact-head one-line workflow diff. Raising only the test-ruby matrix timeout from 10 to 15 minutes gives Ruby 3.3/3.4/4.0 jobs additional runner/setup variance without changing test commands, coverage, fail-fast behavior, required-job aggregation, permissions, action pins, credentials, or any other job timeout. The workflow remains least-privilege, git diff --check passes, all completed exact-head lint/type/package/Bedrock/CodeQL/Castiron checks are green, and only the three Ruby matrix jobs are still running. No blocking correctness, CI-architecture, security, performance, or scope findings.
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed the complete diff and workflow, CI caller, scripts/test, and Rakefile. The job-level timeout correctly changes from 10 to 15 minutes for all Ruby 3.3/3.4/4.0 matrix jobs, covering setup and tests. Test selection/commands, Bedrock coverage, fail-fast behavior, required-job gating, permissions, action pins, and other timeouts remain unchanged. The workflow stays at 178 lines; this direct configuration change introduces no structural complexity or useful missed simplification. No findings.
Validation: git diff --check passes; no local suite or CI reruns performed. Inspected job/step timing metadata: recent run 34188709792 completed the Ruby jobs in 7m08s–7m56s; exact-head run 34245224446 was still running when inspected. This small sample does not establish the slowdown cause or prove 15 minutes sufficient. The bump provides bounded interim headroom; performance investigation remains separate.
3 participants
Ruby test jobs can run close to the current 10-minute limit, leaving too little headroom for setup and runner variance. Increase the
test-rubymatrix job timeout to 15 minutes as an interim measure while test-suite performance is investigated separately.This applies to Ruby 3.3, 3.4, and 4.0. Other job timeouts and test coverage are unchanged.
Validation: reviewed the one-line workflow diff and ran
git diff --check.