Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
==========================================
+ Coverage 95.01% 95.31% +0.30%
==========================================
Files 19 19
Lines 1363 1367 +4
Branches 201 203 +2
==========================================
+ Hits 1295 1303 +8
+ Misses 26 23 -3
+ Partials 42 41 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for reporting this and submitting the PR. The fix itself looks right and Before reviewing further could you tell me a bit about how this PR came together? The description mentions "Generated by Codex", how much of the change and tests you wrote or reviewed yourself versus how much was generated? @SuhrudhC please reply in your own words (not through Codex) with how you came across this issue and whether you've run into it in your own use of the client? That context helps us prioritize, and it helps us know who we're working with on the review. |
Problem and fix
Fixes #125.
An ordinary
client.measurements.list(sensors_id=1, data="days", date_to="2024-01-01")raisesInvalidParameterErrorbecause the validator also requiresdate_from. End-only datetime filters fail similarly. Both bounds are optional in the documented public method and supported independently by the API.Validate supplied end bounds and return them when the start is absent. Retain two-bound ordering checks and validate falsey date ends instead of silently dropping them. The change is confined to date-filter validation and small public-client regressions; it introduces no constructor options or transport changes.
Validation
_has_tomlimport removed to match that branch; the source patch applied cleanly.Targets main per CONTRIBUTING.md. The issue is also present on v1.2.0; I can retarget if preferred. Generated and validated with Codex. Tests use the standard public client and stub outgoing HTTP responses; no
_transportinjection, real credentials, or live API requests are required.