Skip to content

fix(packages): separate taps and normalize package exports - #38

Merged
fullstackjam merged 4 commits into
mainfrom
codex/separate-homebrew-taps
Oct 24, 2026
Merged

fullstackjam merged 4 commits into
mainfrom
codex/separate-homebrew-taps

Conversation

@fullstackjam

@fullstackjam fullstackjam commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

Homebrew sources appeared among software packages, and legacy qualified package names could be typed as taps or exported as repository names to install.

Show sources in a separate collapsible section, derive dependencies from qualified formula/cask names, and allow sources to be retained independently. Normalize legacy types across editing, saving, snapshot/Brewfile import, and both CLI exports. Preserve snapshot-only sources in historical typed configs, then synchronize snapshot sources when saving a new selection so removed sources stay removed. Legacy casks are deduplicated by type, preserving same-named formulae. Storage and CLI response shapes remain unchanged; no database migration is required.

Validation: staged ESLint/Prettier hooks and npm run validate passed. Tests cover source grouping, inference from formulae and casks, legacy imports, historical snapshot-only sources, deletion/save/export round trips, and optional package-update behavior. Browser checks covered the separate source section, automatic removal, independent retention, and Raw-mode type repair.

Review: completed the full diff review and addressed the Codex finding about historical typed lists. The separate Claude review action failed during execution without producing a code review; the required check and validate-commits jobs remain the merge gates.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T14:49:31.150027Z 30fcea6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Oct 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 30fcea600d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/lib/packages.ts Outdated
@fullstackjam
fullstackjam merged commit 8a8cdd3 into main Oct 24, 2026
8 of 9 checks passed
@fullstackjam
fullstackjam deleted the codex/separate-homebrew-taps branch October 24, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant