Repository navigation
fix(scheduler): isolate due checks by job and repository - #246
Closed
vincentkoc wants to merge 1 commit into
Closed
vincentkoc wants to merge 1 commit into
vincentkoc wants to merge 1 commit into
Conversation
vincentkoc
marked this pull request as ready for review
November 16, 2026 02:52
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
A scheduler job can be skipped or run too soon when its name and repository form the same history key as another run. For example, job
sync:repoand jobsyncfor repositoryrepopreviously shared due state.User Impact
Each job/repository pair now follows its own recorded success and interval, even when names contain colons.
Why This Change Was Made
Use an internal pair key for runner due checks. Keep the existing public history lookup, JSON representation, and persisted history format unchanged.
Evidence
GOWORK=off.c6dd9c18d894e72c77807aa75a76c6b034f0dc6fagainst base3853f24e96503325e6bd93b5b63c8d68d9b0142efound no actionable issues. Static review included history handling, runner/caller behavior, and test portability; platform execution is checked separately by CI.