Skip to content

fix(crawlctl): retain job status and relative app selections - #247

Merged
vincentkoc merged 4 commits into
mainfrom
fix/scheduler-history-and-paths-nov16
Nov 16, 2026
Merged

vincentkoc merged 4 commits into
mainfrom
fix/scheduler-history-and-paths-nov16

Conversation

@vincentkoc

@vincentkoc vincentkoc commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

What Problem This Solves

A job can appear never-run when its history key collides with another job, and a relative app selection can fail when the scheduler starts from another directory.

User Impact

Text status reflects each job's latest recorded result, including two runs finishing in the same second. Saved jobs retain the selected executable across working-directory changes.

Why This Change Was Made

Read text status from the original history using exact job identity and append order for tied timestamps. Resolve discovered executable paths before saving jobs.

Follow-up to #242 and #243.

Evidence

  • Reproduced both failures with regressions: colliding job histories in both orders, and a saved relative executable run from another directory.
  • Added and reproduced a same-second failed-to-successful history regression.
  • All regressions pass with the fixes.
  • GOWORK=off: tidy unchanged, go vet ./..., full uncached Go suite, and focused scheduler/crawlctl race tests passed.
  • Independent P0–P3 native review completed with no actionable findings at bdddcc0.
  • Tests use temporary files and synthetic executables.

@clawsweeper

clawsweeper Bot commented Nov 16, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@vincentkoc
vincentkoc marked this pull request as ready for review November 16, 2026 02:54
@vincentkoc
vincentkoc merged commit 7c8666e into main Nov 16, 2026
10 checks passed
@vincentkoc
vincentkoc deleted the fix/scheduler-history-and-paths-nov16 branch November 16, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant