Repository navigation
fix(crawlctl): reject malformed log tail counts - #248
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
crawlctl logs --tailsilently accepts malformed counts such as2junk,1.5, or1e3by reading only their integer prefix.User Impact
Malformed counts now return a usage error before config or log access. Both
--tail VALUEand--tail=VALUErequire a positive integer; valid counts retain their output behavior.Why This Change Was Made
Parse the complete value while retaining the existing positive-count guard. No public library APIs or saved data formats change.
Evidence
+2and02, print exactly the last two lines.GOWORK=off.5f792e1f2e6111f9833cae4b19c1ac3aa047a3deagainst base7c8666e99bb62cd03767d7dd79e368f6dfd23ac3; full diff and unchanged parsing/output/config context reviewed read-only in isolated context.