Skip to content

fix(scheduler): reject unsupported Windows minute intervals - #251

Merged
vincentkoc merged 1 commit into
mainfrom
fix/windows-interval-range
Nov 16, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
fix/windows-interval-range

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Windows schedule planning accepts intervals such as 24h and produces unsupported schtasks /SC MINUTE /MO 1440 commands, so dry-run incorrectly presents them as valid.

User Impact

Windows minute schedules now require whole-minute intervals from 1m through 1439m. Larger intervals return a clear planning error without producing or attempting a task command.

Why This Change Was Made

Enforce the documented Microsoft minute-mode modifier range before command construction. No new schedule modes or conversions are introduced.

Evidence

  • Six baseline failures cover 24h, 1441m, and 100000m through both PlanInstall and Install dry-run; fixed cases reject them without a command.
  • Boundary controls at 1m, 10m, and 1439m retain the exact modifier. Existing whole-minute validation still passes.
  • Module tidiness, vet, full uncached Go tests, formatting, and diff checks pass with GOWORK=off.
  • Independent native P0–P3 review found no findings at complete candidate afa6269218861c094207ecfb8a139e8422d2eabd against base 6dfd4d83a5563d1364c71697b334699bfc03cb3d. Full diff and unchanged planning/install/interval context reviewed read-only in isolated context.
  • Tests plan only; no scheduled tasks are created or changed. No native Task Scheduler integration run is claimed.

@clawsweeper

clawsweeper Bot commented Nov 16, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@vincentkoc
vincentkoc marked this pull request as ready for review November 16, 2026 09:23
@vincentkoc
vincentkoc merged commit 57c1f0f into main Nov 16, 2026
8 checks passed
@vincentkoc
vincentkoc deleted the fix/windows-interval-range branch November 16, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant