Repository navigation
fix(scheduler): reject unsupported Windows minute intervals - #251
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Windows schedule planning accepts intervals such as
24hand produces unsupportedschtasks /SC MINUTE /MO 1440commands, so dry-run incorrectly presents them as valid.User Impact
Windows minute schedules now require whole-minute intervals from 1m through 1439m. Larger intervals return a clear planning error without producing or attempting a task command.
Why This Change Was Made
Enforce the documented Microsoft minute-mode modifier range before command construction. No new schedule modes or conversions are introduced.
Evidence
GOWORK=off.afa6269218861c094207ecfb8a139e8422d2eabdagainst base6dfd4d83a5563d1364c71697b334699bfc03cb3d. Full diff and unchanged planning/install/interval context reviewed read-only in isolated context.