Repository navigation
fix(scheduler): report blank repository jobs as failures - #252
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
A job using
{repo}silently returns success without any runs when every configured repository entry is blank or whitespace.User Impact
Blank-only repository lists now produce the same failed job, saved history record, and nonzero CLI exit as a missing repository list. Lists containing valid repositories still skip blanks and run normally.
Why This Change Was Made
Check for missing repositories after trimming and expansion, where the effective list is known. The existing error and failure-recording path handle the result; no public APIs or saved formats change.
Evidence
GOWORK=off.73c8236e377f18a6d880d5c4e997983ebb0fe432against base57c1f0fffaa473a2eb38e4e8585797651732f7e2. Complete diff and unchanged expansion/failure/history/config/CLI context reviewed read-only in isolated context.