Skip to content

fix(scheduler): report blank repository jobs as failures - #252

Merged
vincentkoc merged 1 commit into
mainfrom
fix/blank-job-repositories
Nov 16, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
fix/blank-job-repositories

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

A job using {repo} silently returns success without any runs when every configured repository entry is blank or whitespace.

User Impact

Blank-only repository lists now produce the same failed job, saved history record, and nonzero CLI exit as a missing repository list. Lists containing valid repositories still skip blanks and run normally.

Why This Change Was Made

Check for missing repositories after trimming and expansion, where the effective list is known. The existing error and failure-recording path handle the result; no public APIs or saved formats change.

Evidence

  • Three blank-only end-to-end CLI regressions fail before the fix and pass afterward; the missing-list control retains its behavior.
  • Assertions cover JSON failed records, exit 1, and persisted failure history; the expansion control confirms mixed blank and valid entries remain supported.
  • Full uncached Go tests, vet, module tidiness, formatting, and diff checks pass with GOWORK=off.
  • Independent native P0–P3 review found no findings in complete candidate 73c8236e377f18a6d880d5c4e997983ebb0fe432 against base 57c1f0fffaa473a2eb38e4e8585797651732f7e2. Complete diff and unchanged expansion/failure/history/config/CLI context reviewed read-only in isolated context.
  • Tests use temporary config and history data; no live stores or crawler commands are used.

@clawsweeper

clawsweeper Bot commented Nov 16, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@vincentkoc
vincentkoc marked this pull request as ready for review November 16, 2026 22:57
@vincentkoc
vincentkoc merged commit 3982145 into main Nov 16, 2026
8 checks passed
@vincentkoc
vincentkoc deleted the fix/blank-job-repositories branch November 16, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant