Repository navigation
fix(crawlctl): honor flag separators during global parsing - #253
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Global flag extraction ignores
--, socrawlctl run -- --versionprints a version instead of running that job;--jsonand--config=...job names can change execution scope or configuration.User Impact
Flag-like job names after
--are treated as literal selections. Global flags before the separator retain their existing behavior.Why This Change Was Made
Stop extracting flags at the separator and preserve the remaining arguments for the command parser. No scheduler APIs or saved formats change.
Evidence
GOWORK=off.ee7a4207fc5b89304346a194a8739ab20c95dc5cagainst base3982145ffb943b58e7d8b4fd1fe6c65948cedd01. Complete diff and unchanged CLI parsing/scheduler execution/temp-path context reviewed read-only in isolated context.