Skip to content

fix(crawlctl): honor flag separators during global parsing - #253

Merged
vincentkoc merged 1 commit into
mainfrom
fix/global-flag-separator
Nov 16, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
fix/global-flag-separator

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Global flag extraction ignores --, so crawlctl run -- --version prints a version instead of running that job; --json and --config=... job names can change execution scope or configuration.

User Impact

Flag-like job names after -- are treated as literal selections. Global flags before the separator retain their existing behavior.

Why This Change Was Made

Stop extracting flags at the separator and preserve the remaining arguments for the command parser. No scheduler APIs or saved formats change.

Evidence

  • Six end-to-end cases fail before the fix: version, JSON, and inline-config job names in text/JSON modes. Fixed cases run only the selected job and preserve the intended output mode.
  • Ordinary job-name controls and JSON output assertions pass; tests use temporary configs/history and the Go test executable without live crawler commands.
  • Full uncached Go suite, vet, module tidiness, formatting, and diff checks pass with GOWORK=off.
  • Independent native P0–P3 review found no findings at complete candidate ee7a4207fc5b89304346a194a8739ab20c95dc5c against base 3982145ffb943b58e7d8b4fd1fe6c65948cedd01. Complete diff and unchanged CLI parsing/scheduler execution/temp-path context reviewed read-only in isolated context.

@clawsweeper

clawsweeper Bot commented Nov 16, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@vincentkoc
vincentkoc marked this pull request as ready for review November 16, 2026 23:14
@vincentkoc
vincentkoc merged commit b9fbd52 into main Nov 16, 2026
8 checks passed
@vincentkoc
vincentkoc deleted the fix/global-flag-separator branch November 16, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant