Repository navigation
fix: keep scheduled runs on the selected config - #255
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
An operator installing a schedule with a relative
--configpath can get a scheduled run that reads a different config or cannot find it. The same problem affects log destinations when the scheduler starts in a different working directory.User Impact
Schedules created through the CLI keep using the selected config and log location, even when launched from another working directory. Unix paths containing a symlink followed by
..keep their original file meaning.Why This Change Was Made
Make relative CLI config paths absolute before loading and rendering the schedule. Preserve Unix path components instead of cleaning them, which could select a different file. Default config routing and the public planning API remain unchanged.
Evidence
..regression confirms the intended config and interval are preserved even when a different config exists at the lexically cleaned path. Independent review caught this edge case and re-review passed after the correction.Validation and review pins
Passed
GOWORK=off go mod tidywith unchanged module files,GOWORK=off go vet ./...,GOWORK=off go test -count=1 ./..., formatting and diff checks.Independent native P0–P3 review: no remaining findings. Base:
d851f550b28721177b91159e895239faa19915c6. Complete candidate:051f75535e30bb520e04d178049810683ab935eb. Scope: full diff, CLI installation, config loading, default path routing, and planner context; isolated read-only review.