Skip to content

fix: keep scheduled runs on the selected config - #255

Merged
vincentkoc merged 1 commit into
mainfrom
fix/install-relative-config
Nov 17, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
fix/install-relative-config

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

An operator installing a schedule with a relative --config path can get a scheduled run that reads a different config or cannot find it. The same problem affects log destinations when the scheduler starts in a different working directory.

User Impact

Schedules created through the CLI keep using the selected config and log location, even when launched from another working directory. Unix paths containing a symlink followed by .. keep their original file meaning.

Why This Change Was Made

Make relative CLI config paths absolute before loading and rendering the schedule. Preserve Unix path components instead of cleaning them, which could select a different file. Default config routing and the public planning API remain unchanged.

Evidence

  • Before the fix, all eight relative-path preview cases emitted relative config paths. They now retain the selected absolute path across all four backends, with both configured and explicitly supplied intervals; cron and launchd log destinations stay absolute too.
  • A symlink/.. regression confirms the intended config and interval are preserved even when a different config exists at the lexically cleaned path. Independent review caught this edge case and re-review passed after the correction.
  • Full tests, static checks, module checks, and independent review passed. Tests render previews only; no native schedules were installed.
Validation and review pins

Passed GOWORK=off go mod tidy with unchanged module files, GOWORK=off go vet ./..., GOWORK=off go test -count=1 ./..., formatting and diff checks.

Independent native P0–P3 review: no remaining findings. Base: d851f550b28721177b91159e895239faa19915c6. Complete candidate: 051f75535e30bb520e04d178049810683ab935eb. Scope: full diff, CLI installation, config loading, default path routing, and planner context; isolated read-only review.

@clawsweeper

clawsweeper Bot commented Nov 17, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@vincentkoc
vincentkoc marked this pull request as ready for review November 17, 2026 07:21
@vincentkoc
vincentkoc merged commit 9a39899 into main Nov 17, 2026
8 checks passed
@vincentkoc
vincentkoc deleted the fix/install-relative-config branch November 17, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant