Repository navigation
fix: let crawlctl show logs for flag-like job names - #256
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
An operator can run a job named
--version, but cannot inspect its logs:crawlctl logs -- --versionrejects the separator as an unknown option.User Impact
crawlctl logs -- JOBcan select jobs whose names look like flags. Earlier options such as--tailstill work, and the command still rejects more than one job name.Why This Change Was Made
Treat everything after the separator as a literal job selection, matching the existing run command. A separator without a job keeps the latest-log behavior.
Evidence
Validation and review pins
Passed
GOWORK=off go mod tidywith unchanged module files,GOWORK=off go vet ./...,GOWORK=off go test -count=1 ./..., formatting and diff checks.Independent native P0–P3 review: no findings. Base:
9a398997ca32739e78c2176c85b83b1fc0b9a0da. Complete candidate:8e3f98f27e343f6db977608c9d31080f488e3037. Scope: full diff, flag hoisting, dispatch, logs parsing, tail validation, and history selection; isolated read-only review.