Skip to content

fix: preserve whitespace in selected mirror commit paths - #260

Merged
vincentkoc merged 1 commit into
mainfrom
fix/mirror-literal-whitespace-paths
Nov 19, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
fix/mirror-literal-whitespace-paths

Conversation

@vincentkoc

@vincentkoc vincentkoc commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

What Problem This Solves

A mirror commit selecting report.json could commit report.json instead, leaving the requested file unchanged. Whitespace-only filenames were silently skipped.

User Impact

User impact: selected mirror paths preserve their leading and trailing whitespace, and unrelated staged files stay out of the commit.

Why This Change Was Made

Stop trimming selected paths before passing them to Git. Empty entries still do nothing; literal Git path selection is unchanged.

Evidence

The new temporary-repository regression failed before the fix for leading, trailing, and whitespace-only filenames. All focused commit-path tests pass after the fix, including checks that unrelated staged content remains staged.

Independent native review found no P0–P3 issues in candidate 4db0ea997105f7b932a13a1b79fa2b03a199abe6 against 5ceb54896c21021b21d2221d0eaa3d5fbabe79e7.

After rebasing onto the literal-path selection fix, make check passed: module tidiness, formatting, vet, dead-code analysis, vulnerability checks, the full unit and race suites, and all 47 release-script tests. A separate GOWORK=off go test -count=1 ./... passed. Tests use temporary Git repositories; no live archives are touched.

@clawsweeper

clawsweeper Bot commented Nov 19, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@vincentkoc
vincentkoc marked this pull request as ready for review November 19, 2026 13:09
@vincentkoc
vincentkoc force-pushed the fix/mirror-literal-whitespace-paths branch from 7d044a3 to 4db0ea9 Compare November 19, 2026 13:12
@vincentkoc
vincentkoc merged commit 5f45abf into main Nov 19, 2026
8 checks passed
@vincentkoc
vincentkoc deleted the fix/mirror-literal-whitespace-paths branch November 19, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant