Repository navigation
fix: preserve whitespace in selected mirror commit paths - #260
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
vincentkoc
marked this pull request as ready for review
November 19, 2026 13:09
vincentkoc
force-pushed
the
fix/mirror-literal-whitespace-paths
branch
from
November 19, 2026 13:12
7d044a3 to
4db0ea9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
A mirror commit selecting
report.jsoncould commitreport.jsoninstead, leaving the requested file unchanged. Whitespace-only filenames were silently skipped.User Impact
User impact: selected mirror paths preserve their leading and trailing whitespace, and unrelated staged files stay out of the commit.
Why This Change Was Made
Stop trimming selected paths before passing them to Git. Empty entries still do nothing; literal Git path selection is unchanged.
Evidence
The new temporary-repository regression failed before the fix for leading, trailing, and whitespace-only filenames. All focused commit-path tests pass after the fix, including checks that unrelated staged content remains staged.
Independent native review found no P0–P3 issues in candidate
4db0ea997105f7b932a13a1b79fa2b03a199abe6against5ceb54896c21021b21d2221d0eaa3d5fbabe79e7.After rebasing onto the literal-path selection fix,
make checkpassed: module tidiness, formatting, vet, dead-code analysis, vulnerability checks, the full unit and race suites, and all 47 release-script tests. A separateGOWORK=off go test -count=1 ./...passed. Tests use temporary Git repositories; no live archives are touched.