Repository navigation
fix: optimize the exact selected FTS table - #261
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Optimizing an FTS table named
docstargeteddocsinstead. Ifdocswas an ordinary table with a matching column, the call silently inserted anoptimizerow into it; if absent, optimization failed.User Impact
User impact: FTS optimization uses the exact selected table name, including surrounding whitespace, without modifying a similarly named table.
Why This Change Was Made
Keep whitespace trimming for blank-name validation only. Preserve the supplied name when quoting the SQL identifier; existing invalid-name checks remain.
Evidence
Real temporary SQLite regressions reproduced the unwanted insertion for leading, trailing, and surrounding whitespace. After the fix, the store suite passes; the tests verify the neighboring table stays empty and optimization also succeeds without that neighbor.
Independent native review found no P0–P3 issues in
f0109e5e2ef8567028bbaa647eedec23f43621d5against5f45abfb45255e289f219f9bd0e58c819fd556cb.make checkpassed: module tidiness, formatting, vet, dead-code analysis, vulnerability checks, full unit and race suites, and all 47 release-script tests. A separateGOWORK=off go test -count=1 ./...passed. No live archives are used.