Repository navigation
fix: preserve selected SQLite snapshot names - #263
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
A SQLite capture named
archive.dbwas saved asarchive.db, replacing that neighboring database and its WAL/SHM files. A whitespace-only name silently selected the source basename instead.User Impact
User impact: SQLite captures retain the selected filename, including whitespace. On Windows, ambiguous trailing spaces or dots are rejected before replacing any destination files.
Why This Change Was Made
Preserve the explicit name and apply the existing platform path validation to the complete destination. The empty-name fallback and bundle replacement/rollback behavior remain unchanged.
Evidence
Temporary-file regressions reproduced neighboring main/WAL/SHM replacement before the fix. The cache suite now passes, including preservation of all neighboring files and Windows-specific name rejection expectations.
Independent native review found no P0–P3 issues in
56cbf58e956e4d82d3ac1275a690b4ae2516e686againstc0f2e1c0573a6509e321d95a9103b7d42ad0b5e3.make checkpassed: module tidiness, formatting, vet, dead-code analysis, vulnerability checks, full unit and race suites, and all 47 release-script tests. A separateGOWORK=off go test -count=1 ./...passed. Tests use temporary files only.