Skip to content

fix: preserve selected SQLite snapshot names - #263

Merged
vincentkoc merged 1 commit into
mainfrom
fix/sqlite-snapshot-literal-names
Nov 20, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
fix/sqlite-snapshot-literal-names

Conversation

@vincentkoc

@vincentkoc vincentkoc commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

What Problem This Solves

A SQLite capture named archive.db was saved as archive.db, replacing that neighboring database and its WAL/SHM files. A whitespace-only name silently selected the source basename instead.

User Impact

User impact: SQLite captures retain the selected filename, including whitespace. On Windows, ambiguous trailing spaces or dots are rejected before replacing any destination files.

Why This Change Was Made

Preserve the explicit name and apply the existing platform path validation to the complete destination. The empty-name fallback and bundle replacement/rollback behavior remain unchanged.

Evidence

Temporary-file regressions reproduced neighboring main/WAL/SHM replacement before the fix. The cache suite now passes, including preservation of all neighboring files and Windows-specific name rejection expectations.

Independent native review found no P0–P3 issues in 56cbf58e956e4d82d3ac1275a690b4ae2516e686 against c0f2e1c0573a6509e321d95a9103b7d42ad0b5e3. make check passed: module tidiness, formatting, vet, dead-code analysis, vulnerability checks, full unit and race suites, and all 47 release-script tests. A separate GOWORK=off go test -count=1 ./... passed. Tests use temporary files only.

@clawsweeper

clawsweeper Bot commented Nov 20, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@vincentkoc
vincentkoc marked this pull request as ready for review November 20, 2026 04:08
@vincentkoc
vincentkoc merged commit 545c129 into main Nov 20, 2026
8 checks passed
@vincentkoc
vincentkoc deleted the fix/sqlite-snapshot-literal-names branch November 20, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant