Skip to content

build(deps): bump trufflesecurity/trufflehog from 3.99.3 to 3.99.8 - #358

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/github_actions/trufflesecurity/trufflehog-3.99.8
Closed

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/github_actions/trufflesecurity/trufflehog-3.99.8

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 5, 2026

Copy link
Copy Markdown
Contributor

Bumps trufflesecurity/trufflehog from 3.99.3 to 3.99.8.

Release notes

Sourced from trufflesecurity/trufflehog's releases.

v3.99.8

What's Changed

New Contributors

Full Changelog: trufflesecurity/trufflehog@v3.99.7...v3.99.8

v3.99.7

What's Changed

New Contributors

Full Changelog: trufflesecurity/trufflehog@v3.99.6...v3.99.7

v3.99.6

v3.99.5 was tagged but never published because its release build failed. v3.99.6 supersedes it and includes all of the changes below.

What's Changed

... (truncated)

Commits
  • ea68ca0 Verify BoxOauth credentials only when Box issues a token for a subject (#5498)
  • 7238e0e Clean up GitLab source logging for per-source debug (#5485)
  • 5a3176f Update module github.com/mattn/go-isatty to v0.0.24 (#5366)
  • a74daf6 Update module github.com/jlaffaye/ftp to v0.2.4 (#5365)
  • 1641840 Update module github.com/go-git/go-git/v5 to v5.19.3 (#5480)
  • ee5d0d2 Cap 7z LZMA and LZMA2 dictionary sizes and keep scanning past refused entries...
  • 421026a Recover from detector panics in the verification overlap worker (#5495)
  • 6973459 Close Couchbase clusters after verification and honor the context (#5489)
  • 87adc84 Add source fields to Init logs in single-source CLI commands (#5466)
  • 020634e Clean up Docker source logging for per-source debug (#5494)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [trufflesecurity/trufflehog](https://github.com/trufflesecurity/trufflehog) from 3.99.3 to 3.99.8.
- [Release notes](https://github.com/trufflesecurity/trufflehog/releases)
- [Commits](trufflesecurity/trufflehog@e63326d...ea68ca0)

---
updated-dependencies:
- dependency-name: trufflesecurity/trufflehog
  dependency-version: 3.99.8
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot requested a review from a team as a code owner November 5, 2026 18:43
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Nov 5, 2026
@clawsweeper

clawsweeper Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. labels Nov 5, 2026
@clawsweeper

clawsweeper Bot commented Nov 5, 2026

Copy link
Copy Markdown

Codex review: blocked before merge.

What this changes

This PR updates the pinned TruffleHog action reference from v3.99.3 to v3.99.8.

Example: A pull request runs the secret-scanning workflow.

  • Before: The v3.99.3 action wrapper invokes scanner image 3.99.4.
  • After: The identical v3.99.8 action wrapper still invokes scanner image 3.99.4.

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) The narrowly scoped patch has no identified correctness defect, but its operational value conflicts with the prior maintainer decision.
Proof confidence 🌊 off-meta tidepool Not applicable: This Dependabot reference-only update is outside the contributor proof gate and changes no executable action behavior; successful scan checks were observed, but hosted runtime logs were inaccessible.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: No · Fix scope: Complete
User problem: No user-visible problem is resolved because the executed scanner remains unchanged.
Reason: The same executable action blob and runtime pin reproduce the no-uplift condition that a maintainer cited when closing #276.

Merge readiness

⛔ Blocked before merge - 1 item remains

This PR introduces no identified defect, but delivers no scanner upgrade or executable action change; a maintainer previously closed the equivalent wrapper-only update, and repository policy does not authorize automatic closure here.

Priority: P3
Reviewed head: 8b084e11cf11103fdc98880d74e858c6d5346da7
Owner decision: Required. See Decision needed.

Decision needed

  • Question: Should this wrapper-only refresh be declined consistently with the prior equivalent update?
  • Recommendation: Decline the wrapper-only refresh: Use the ordinary manual close workflow, following the decision recorded on build(deps): bump trufflesecurity/trufflehog from 3.99.3 to 3.99.7 #276 (comment).
  • Why: The executable action is identical and the scanner remains 3.99.4, but repository cleanup policy permits automatic closure only for implemented changes.

Before merge

Findings

None.

Agent review details

How this fits together

GitHub Actions resolves the changed commit range and passes it to TruffleHog, which fails the security gate when verified secrets are found.

flowchart TD
  A[Push or pull request] --> B[Checkout repository history]
  B --> C[Resolve scan range]
  C --> D[Pinned TruffleHog action]
  D --> E[Scanner image 3.99.4]
  E --> F[Verified secret gate]
Loading

Technical review

Best possible solution:

Follow the prior maintainer decision and reserve scanner upgrades for a focused change that updates and qualifies the explicit runtime artifact.

Do we have a high-confidence way to reproduce the issue?

No product bug is asserted; source inspection establishes that the proposed reference change leaves executed scanner behavior unchanged.

Is this the best way to solve the issue?

The patch correctly refreshes the wrapper reference, but cannot deliver the advertised upstream scanner improvements while the runtime remains pinned to 3.99.4.

AGENTS.md: found but not applied because it conflicted with ClawSweeper's review contract.

Codex review notes: model internal, reasoning medium; reviewed against b39ecf743295.

Provenance checked

Security

None.

Evidence

What I checked:

  • Exact introduced change: The sole introduced hunk changes the action SHA and version comment; scanner version 3.99.4, permissions, scan range, verification flags and failure handling remain unchanged. (.github/workflows/secret-scan.yml:52, 8b084e11cf11)
  • Current main: Current main still pins action v3.99.3 and scanner image 3.99.4, so the proposed reference update is not already implemented. (.github/workflows/secret-scan.yml:52, b39ecf743295)
  • Executed dependency contract: The workflow directly executes this composite action. Both revisions have the identical action.yml blob 1e2af3fbb9ef7eb5f19e21af9d0c6c3278de1a73, including Docker image selection through the version input. The v3.99.8 tag resolves to the proposed SHA; no root AGENTS.md exists there. (action.yml:21, ea68ca03c865)
  • Relevant maintainer decision: At build(deps): bump trufflesecurity/trufflehog from 3.99.3 to 3.99.7 #276 (comment), member vincentkoc closed the equivalent wrapper-only update because identical action content and the explicit 3.99.4 runtime provide no operational uplift; they directed scanner updates to change and qualify the runtime artifact.
  • Preserved runtime qualification: fix(ci): pin qualified TruffleHog runtime image #272 deliberately selected the qualified 3.99.4 scanner runtime through the existing version input; this PR preserves that decision. (.github/workflows/secret-scan.yml:54, f1c40bc03f86)
  • Checks and inspection limits: Both secret-scanning checks succeeded on the reviewed head; Go / xcode-27 remained in progress. Hosted job logs redirected to a blocked storage domain, so their runtime output was not inspected. Local follow-history reached the documented missing-object boundary; available commits, diffs and current-main blame were inspected. (.github/workflows/secret-scan.yml:12, 8b084e11cf11)

Likely related people:

  • Vincent Koc: Raw commit a4ab91b adds .github/workflows/secret-scan.yml:13 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: a4ab91b035da; files: .github/workflows/secret-scan.yml)
  • Josh Avant: Raw commit f1c40bc adds .github/workflows/secret-scan.yml:54 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: f1c40bc03f86; files: .github/workflows/secret-scan.yml)
  • Peter Steinberger: Raw commit f80cc94 adds .github/workflows/secret-scan.yml:19 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: f80cc94dcdbd; files: .github/workflows/secret-scan.yml)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Labels

Label changes:

  • add P3: This is a reference-only maintenance update with identical executable action content and unchanged scanner runtime.
  • add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.

Label justifications:

  • P3: This is a reference-only maintenance update with identical executable action content and unchanged scanner runtime.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed November 5, 2026, 1:57 PM ET / 18:57 UTC.

@vincentkoc vincentkoc closed this Nov 9, 2026
@dependabot @github

dependabot Bot commented on behalf of github Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/github_actions/trufflesecurity/trufflehog-3.99.8 branch November 9, 2026 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant