Version 1.20260723.1#589
Merged
Merged
Conversation
…e-after-free on instance deletion. Indeed, the global `sRuntimes` cache shared one JIT-compiled runtime across all `SedInstance` objects for the same CellML file. When an instance was destroyed, the cached runtime's JIT-compiled code still referenced the old thread-local solver address (`sNlaSolverAddress`), which pointed to freed memory on std::async thread-pool reuse. Each instance now creates its own runtime, eliminating the shared-state corruption.
There was a problem hiding this comment.
Pull request overview
Updates the project version and changes how CellmlFile produces CellmlFileRuntime instances by removing the compiled-runtime cache/cleanup logic in CellmlFile.
Changes:
- Bump
VERSION.txtfrom1.20260723.0to1.20260723.1. - Remove
CellmlFile’s explicit destructor and the global runtime cache;CellmlFile::runtime()now always creates a new runtime.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| VERSION.txt | Increments the library version string. |
| src/support/cellml/cellmlfile.h | Removes the explicit CellmlFile destructor declaration. |
| src/support/cellml/cellmlfile.cpp | Removes the global runtime cache and returns a freshly created runtime on every call. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.