Repository navigation
Conversation
3f650dc to
3d80bf7
Compare
…0 and Test#445 Test#180 now verifies release.yml's push branch matches the repo's actual default branch (via gh repo view) and flags the mismatch with a concrete fix instruction. Repos like django-wiki use edx_release, not master, so the standard template would silently never release. Test#445 gains a note that a dead push trigger (wrong branch name) masks the double-run bug — both tests must be fixed together when the default branch is not master. References: - openedx/platform-plugin-aspects#257 (original double-run fix) - openedx/django-wiki#329 (first non-master default branch case) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Caution
This repo's default branch is Why this is a breaking change: The existing As currently written, Fix: Update the three occurrences in
@feanil -- Can you please look/share your thoughts into this issue or tag the relevant maintainer |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
caac099 to
3b83232
Compare
|
That makes sense to me. |
Important
PR implemented with the assistance of Claude Code. Refined and validated before being submitted for code review.
Modernize `django-wiki`
Part of openedx/public-engineering#506
Summary
openedx-django-wikiRemoved/Updated
Deleted files: `setup.py`, `requirements/`
Removed Makefile targets:
Updated Makefile targets:
Python 3.8–3.11 dropped
Python 3.8–3.11 reached end-of-life and Open edX Sumac+ dropped them platform-wide. The project already only tested Python 3.12; `requires-python = ">=3.12"` is now set explicitly.
Versioning
`setuptools-scm` with `dynamic = ["version"]` — master had a PyPI publish workflow; `python-semantic-release` controls the version string at release time via git tags.
CI / Release workflow fixes
This repo's default branch is `edx_release`, not `master`. The standard `release.yml` template ships with `branches: [master]` and two `if: github.ref_name == 'master'` guards, which meant PSR and PyPI publish would never run after merge.
Fixed in this PR:
Important Notes
Testing Notes
This PR has not been manually tested against the repo's own features. Testing relied on CI checks and local agent tooling (`make upgrade`, `uv run tox`, `python -m build`). Repo-owner is encouraged to run the repo's feature tests before merging.
🤖 Generated with Claude Code