Repository navigation
Conversation
release.yml calls ci.yml via workflow_call on every push to master, so the separate push: trigger in ci.yml fired CI twice concurrently. Both runs raced to upload to the Codecov coverage data branch. Remove the push: trigger from ci.yml; release.yml's workflow_call covers pushes to master already. Also replace the "Version bumped" PR template checklist item with a Conventional Commits reminder — versioning is now automated by python-semantic-release and the manual checkbox is misleading. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
CI failures are pre-existing — not introduced by this PRBoth failing jobs (
The Codecov CLI binary download fails mid-TLS-handshake on the GitHub Actions runner. The signature check error is a downstream consequence — there is nothing to verify because the download never completed. This is a runner-side network blip, not a code issue.
The e2e tox run is killed before completion ( Evidence this is pre-existing:
|
farhan
marked this pull request as ready for review
October 5, 2026 08:19
bmtcril
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inspired by openedx/platform-plugin-aspects#257 (fix by @bmtcril).
push: branches: [master]trigger fromci.ymlProblem
release.ymlcallsci.ymlviaworkflow_callon every push tomaster. With a separatepush: branches: [master]trigger also present inci.yml, every merge fires CI twice concurrently — both runs race to upload coverage data to Codecov, which can cause flaky failures.This is visible in the run history: every push to master generates a paired
ci.ymlrun (from the push trigger) and arelease.ymlrun (which internally re-runs all ofci.ymlviaworkflow_call):2026-09-08T06:31 — "fix: make the Typesense search backend usable (fix: make the Typesense search backend usable #289)"
→ CI run #34195019543 (push trigger, success)
→ Release run #34195019748 (workflow_call, failed at release step)
2026-09-08T06:29 — "fix: do not update LMS user during retirement (fix: do not update LMS user during retirement #239)"
→ CI run #34194867769 (push trigger, success)
→ Release run #34194868114 (workflow_call, failed at release step)
The same bug was introduced in
openedx/platform-plugin-aspectsPR #253 and fixed in PR #257 by @bmtcril.Fix
Remove the
push:trigger fromci.yml. Therelease.yml→workflow_callpath already covers pushes tomaster, so CI still runs on every merge — just once.PR template update
python-semantic-releaseautomates versioning from commit message types, so "Version bumped" is no longer a meaningful manual step. Replaced with a Conventional Commits reminder so contributors know which prefix triggers which release tier.Testing Notes
No logic changes — only CI trigger configuration. Verified by inspecting the workflow files. The fix matches exactly what was applied in
platform-plugin-aspectsPR #257.Important
PR implemented with the assistance of Claude Code. Refined and validated before being submitted for code review.