Skip to content

Some fixes for pressure handling - #215

Open
mattwthompson wants to merge 6 commits into
mainfrom
pressure-fixes
Open

mattwthompson wants to merge 6 commits into
mainfrom
pressure-fixes

Conversation

@mattwthompson

Copy link
Copy Markdown
Member

Description

Fixes #213

Checklist

@codecov-commenter

codecov-commenter commented Nov 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.11%. Comparing base (0d410bb) to head (5473dbf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files          58       58           
  Lines        5311     5311           
=======================================
  Hits         4361     4361           
  Misses        950      950           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mattwthompson

mattwthompson commented Nov 8, 2026 •

Copy link
Copy Markdown
Member Author

This is passing locally, but I need to get GPU-enabled tests up and running to ensure workflows actually proceed as expected

I'm getting this error in the GPU action:

Retry AssumeRole: attempt 12 of 12 failed: Could not assume role with OIDC: Not authorized to perform sts:AssumeRoleWithWebIdentity. Retrying after 952ms.
Retry AssumeRole: reached max retries (12); giving up.

I basically copied it over from a file of the same name in the NAGL repo. Possibly something needs to be reconfigured in our org's AWS IAM, I do not have the keys so that will have to wait.

I split this off into #216 now

@mattwthompson mattwthompson mentioned this pull request Nov 8, 2026
4 tasks
@mattwthompson

Copy link
Copy Markdown
Member Author

My Copilot subscription/preview/trial/idk has ended but I was able to ask their harness to review and it gave verbose and mildly positive feedback: https://github.com/copilot/c/a7ee57d3-4ef8-4f4f-a508-d5ddf5b29a4e

I doubt the link is public, though, so ... useless?

@mattwthompson
mattwthompson marked this pull request as ready for review November 8, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More issues with pressure

2 participants