Repository navigation
Conversation
… value, quoted like Xcode does (openframeworks#303)
Member
Author
|
Combined into #683. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #303.
The JSON pbxproj writer appended only the first word of a value to array build settings (
cols[3]of the space-split command), soHEADER_SEARCH_PATHSgotsrc/subforsrc/sub folderand../addons/ofxSpacefor../addons/ofxSpace Addon/src. Now the whole value is kept, and a value with spaces is stored quoted ("src/sub folder") the way Xcode itself writes such paths, since Xcode splits build settings on whitespace. Addon flags are already split into single words before this, so they're unchanged.Before / after, project
my projwithsrc/test 2.h,src/sub folder/deep.h, addon../addons/ofxSpace Addonwithsrc/inner dir/sp.h:#include "..."already worked through Xcode's header map;#include <deep.h>/<sp.h>(search paths only) failed on master with'deep.h' file not found with <angled> includeand builds with this (xcodebuildRelease arm64).xcodebuild -showBuildSettingsexpands them as single quoted paths.