Improve libMesh tally performance#3978
Closed
nuclearkevin wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I had been noticing a fairly substantial performance penalty when using libMesh unstructured mesh tallies and a mesh that only covers a portion of the domain. The performance penalty scaled with the number of elements in the mesh (so long as the mesh did not fully cover the domain), and would disappear if the mesh fully covered the problem. After perusing the libMesh doxygen for the point locators, namely the accessor function, I discovered that libMesh will perform a linear search over all mesh elements in the event that an element containing a point was not found after querying spatial trees. This behaviour can be
fixedslightly improved by callingPointLocatorBase::unset_close_to_point_tol(), which sets_use_close_to_point_tol = falseand disables the linear search.After some more testing this only results in a slight increase in performance for these problems, and only for wrapped applications that were setting the flag behind the scenes (e.g. MOOSE).
Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)