Repository navigation
Conversation
Signed-off-by: arcwiser <arcwiser@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata
output_formatto"dataframe"聽#1115list_setupsto DataFrame outputDetails
list_setupswas the remaining listing API whose default output was not a pandas DataFrame. This changes its default from"object"to"dataframe"while preserving explicitoutput_format="object"support for callers that needOpenMLSetupinstances.The DataFrame construction now declares its columns so an empty server response returns an empty DataFrame with the same
setup_idindex andflow_id/parameterscolumns as a populated response.Tests cover populated and empty default results without requiring a server. Existing integration coverage now verifies the DataFrame default and the explicit object compatibility path.
Tested on Windows with Python 3.10:
pytest tests/test_setups/test_setup_functions.py::test_list_setups_defaults_to_dataframe -q(2 passed)pytest tests/test_setups/test_setup_functions.py -m "not production_server and not test_server" -q(2 passed, 10 deselected)pytest tests/test_setups/test_setup_functions.py::TestSetupFunctions::test_list_setups_output_format -qagainst the production OpenML API (1 passed)pre-commit run --files openml/setups/functions.py tests/test_setups/test_setup_functions.py(all hooks passed)git diff --check upstream/main HEADAI-assisted: yes. The contributor reviewed and is responsible for the submitted changes.