Repository navigation
Conversation
josvandervelde
left a comment
josvandervelde
left a comment
Member
There was a problem hiding this comment.
Nice work! It would be great to have automatic tests.
I added some comments. Other than that: it would be nice to mention the existence of these tests in the README.md, under ## Development, I think. A brief mention would be perfect.
josvandervelde
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Work in progress. It's not in draft state because it wouldn't trigger CI, which I want to trigger to test whether the PR works as expected.
This PR adds CI so that we can automatically test whether or not a configuration update breaks anything.
There is a known issue with run upload/download in PHP v1.2.4, it scripts work with a more recent version of the API. Waiting for #21 to be merged.
It would be good to also add coverage of the
croissants,arff-to-pq,elasticsearchandfrontendservices to at least cover the core platform services, but I am keeping it out of scope for this PR. The current scope covers thereadmefunctionalities.