Skip to content

Fix moving NPC vehicle pitch not synced #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fanorisky wants to merge 5 commits into
base: master
Choose a base branch
from
+16 −1
Open

Fix moving NPC vehicle pitch not synced #1249

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
add21aa
fix moving npc vehicle pitch
Fanorisky Jun 10, 2026
e52f9ee
Merge branch 'master' into master
Fanorisky Aug 2, 2026
f2ffa63
restore removed comments and blank lines
Fanorisky Aug 7, 2026
fd35c3c
apply npc vehicle pitch in move using glm helpers
Fanorisky Aug 8, 2026
9a3fd8d
move pitch reset into the move type branches
Fanorisky Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion Server/Components/NPCs/NPC/npc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,22 @@ bool NPC::move(Vector3 pos, NPCMoveType moveType, float moveSpeed, float stopRan
front = (pos - position) / distance;
auto rotation = getRotation().ToEuler();
rotation.z = getAngleOfLine(front.x, front.y);
rotation_ = GTAQuat(rotation); // Do this directly, if you use NPC::setRotation it's going to cause recursion

if (moveType_ == NPCMoveType_Drive)
{
rotation.x = 0.0f; // The slope pitch is recalculated below, drop whatever a previous move left here
rotation_ = GTAQuat(rotation); // Do this directly, if you use NPC::setRotation it's going to cause recursion

// Tilt the vehicle to match the slope towards the target
const float pitch = -atan2(front.z, glm::length(glm::vec2(front)));
const float yaw = glm::roll(rotation_.q); // glm is Y up, so its roll() is the rotation around our Z axis
rotation_.q = glm::angleAxis(pitch, Vector3(1.0f, 0.0f, 0.0f)) * glm::angleAxis(yaw, Vector3(0.0f, 0.0f, 1.0f));
}
else
{
rotation.x = 0.0f; // A previous drive move may have left a pitch here, it would make the ped lean
rotation_ = GTAQuat(rotation); // Do this directly, if you use NPC::setRotation it's going to cause recursion
}

// Calculate velocity to use on tick
velocity_ = front * (moveSpeed_ / 100.0f);
Expand Down