Drop the pointer to the bucket functions from the function list - #5714
Open
RyanL1997 wants to merge 1 commit into
Open
Drop the pointer to the bucket functions from the function list#5714RyanL1997 wants to merge 1 commit into
RyanL1997 wants to merge 1 commit into
Conversation
Follow-up to a review comment on opensearch-project#5700: calling them bucket functions is already the name other databases use, so a reader looking for them under that name does not need the signpost. The section they point at, under GROUP BY in `aggregations.rst`, stays. Signed-off-by: Jialiang Liang <ryanleeang@gmail.com>
RyanL1997
requested review from
LantaoJin,
Swiddis,
acarbonetto,
ahkcs,
anirudha,
dai-chen,
joshuali925,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
songkant-aws,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
August 21, 2026 19:40
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to this comment on #5700.
functions.rstgained a line pointing at the bucket functions, saying they are documented under GROUP BY rather than in the function list. Calling them bucket functions is already the name other databases use, so a reader looking for them under that name does not need the signpost.The section it pointed at —
Bucket Function, under GROUP BY Clause inaggregations.rst— stays as it is.Related Issues
Follow-up to #5700
Check List
functions.rstandaggregations.rst.--signoff.