CNTRLPLANE-3871: promote OSStreams feature gate to Default for Hypershift

[jparrill]

Summary

• Promote the OSStreams feature gate from TechPreview to Default on the Hypershift cluster profile
• This collapses two profile-scoped enable() calls into one profile-agnostic call, making OSStreams enabled in Default and OKD for both SelfManaged and Hypershift profiles
• Re-submission of CNTRLPLANE-3871: promote OSStreams feature gate to Default for Hypershift #2950 (reverted by TRT-2908: Revert "CNTRLPLANE-3871: promote OSStreams feature gate to Default for Hypershift" #2989 due to a latent MCO bug now fixed by CNTRLPLANE-3840: skip network-based OSImageStream discovery in HyperShift machine-config-operator#6420)

Context

The previous submission (#2950) was reverted because MCC bootstrap performed network-based image inspection through the guest cluster's proxy, which is unreachable from the management cluster. The MCO fix (openshift/machine-config-operator#6420) skips network discovery in ExternalTopologyMode and builds OSImageStream status from the ControllerConfig's already-resolved OS images.

Dependencies

• CNTRLPLANE-3840: skip network-based OSImageStream discovery in HyperShift machine-config-operator#6420 must merge first (or concurrently) to prevent the same CI regression

Test plan

• Verify hypershift-e2e-aws passes (specifically TestCreateClusterProxy)
• Verify standalone cluster tests are unaffected
• Verify feature gate tables in generated YAMLs are correct

🤖 Generated with Claude Code

[openshift-ci-robot]

@jparrill: This pull request references CNTRLPLANE-3871 which is a valid jira issue.

Details

In response to this:

Summary

• Promote the OSStreams feature gate from TechPreview to Default on the Hypershift cluster profile
• This collapses two profile-scoped enable() calls into one profile-agnostic call, making OSStreams enabled in Default and OKD for both SelfManaged and Hypershift profiles
• Re-submission of CNTRLPLANE-3871: promote OSStreams feature gate to Default for Hypershift #2950 (reverted by TRT-2908: Revert "CNTRLPLANE-3871: promote OSStreams feature gate to Default for Hypershift" #2989 due to a latent MCO bug now fixed by CNTRLPLANE-3840: skip network-based OSImageStream discovery in HyperShift machine-config-operator#6420)

Context

The previous submission (#2950) was reverted because MCC bootstrap performed network-based image inspection through the guest cluster's proxy, which is unreachable from the management cluster. The MCO fix (openshift/machine-config-operator#6420) skips network discovery in ExternalTopologyMode and builds OSImageStream status from the ControllerConfig's already-resolved OS images.

Dependencies

• CNTRLPLANE-3840: skip network-based OSImageStream discovery in HyperShift machine-config-operator#6420 must merge first (or concurrently) to prevent the same CI regression

Test plan

• Verify hypershift-e2e-aws passes (specifically TestCreateClusterProxy)
• Verify standalone cluster tests are unaffected
• Verify feature gate tables in generated YAMLs are correct

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @jparrill! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d3d985ed-44eb-49fd-ae0f-f465402e31f3

📥 Commits

Reviewing files that changed from the base of the PR and between af5c920 and ef49c15.

⛔ Files ignored due to path filters (10)

• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigpools-Hypershift-CustomNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigpools-Hypershift-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigpools-Hypershift-DevPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigpools-Hypershift-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigpools-Hypershift-TechPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigpools.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_osimagestreams-Hypershift.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_osimagestreams.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1alpha1/zz_generated.crd-manifests/0000_80_machine-config_01_osimagestreams-Hypershift.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1alpha1/zz_generated.crd-manifests/0000_80_machine-config_01_osimagestreams.crd.yaml is excluded by !**/zz_generated.crd-manifests/*

📒 Files selected for processing (12)

• features.md
• features/features.go
• payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-CustomNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-Default.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-DevPreviewNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-OKD.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-TechPreviewNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_machineconfigpools.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_osimagestreams-Hypershift.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_osimagestreams.crd.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml

💤 Files with no reviewable changes (6)

• payload-manifests/crds/0000_80_machine-config_01_osimagestreams-Hypershift.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-OKD.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-TechPreviewNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-CustomNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-DevPreviewNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-Default.crd.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.

---

📝 Walkthrough

Walkthrough

OSStreams enablement now covers development preview, technology preview, default, and OKD configurations. Hypershift Default and OKD payload feature gates enable OSStreams. Hypershift-specific MachineConfigPool and OSImageStream CRD manifests were removed. The remaining MachineConfigPool and OSImageStream CRDs now include IBM Cloud managed release annotations. The feature table reflects enabled status across the listed platform and release profiles.

Possibly related PRs

• openshift/api#2989: Directly reverses related OSStreams changes by removing Hypershift CRDs and re-enabling OSStreams for Hypershift Default and OKD.

Suggested reviewers: everettraven, joelspeed

Merge Risk: 🔵 Low · up to ef49c

This change enables OSStreams by default for Hypershift and depends on the corresponding bootstrap fix being included in the tested release. The PR is mergeable with owner awareness, but that dependency and the Hypershift bootstrap test should be confirmed before merging.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the promotion of the OSStreams feature gate to Default for Hypershift.
Description check	✅ Passed	The description explains the feature promotion, implementation changes, dependency, context, and planned tests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The commit changes feature metadata and manifests only; it adds no *_test.go files or Ginkgo title calls, so it introduces no unstable test names.
Test Structure And Quality	✅ Passed	The PR changes feature metadata and generated YAML manifests only; the verified diff contains no Ginkgo or test implementation changes to assess against these requirements.
Microshift Test Compatibility	✅ Passed	The PR adds no Ginkgo e2e tests. The diff contains only feature declarations and manifests, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The diff adds no Ginkgo tests or test files; it changes feature declarations and CRD/feature-gate manifests only, so SNO test compatibility is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff changes feature-gate declarations and CRD/feature-gate YAML only. It adds no deployments, controllers, or topology-related scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The diff changes one feature-gate initializer and manifests only; it adds no main/init/TestMain/Ginkgo setup or stdout write.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request changes feature gates and CRD manifests only; the diff adds no *_test.go files or Ginkgo It/Describe/Context/When tests to assess.
No-Weak-Crypto	✅ Passed	The PR changes feature-gate and CRD metadata only; the exact added-line scan found no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret-comparison code.
Container-Privileges	✅ Passed	The PR diff only changes feature gates and CRD manifests; added-line and final-file scans found no privileged:true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation:true.
No-Sensitive-Data-In-Logs	✅ Passed	The HEAD diff changes feature declarations, tables, and CRD/feature-gate YAML only; added-line and AST searches found no logging calls or sensitive values.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment