ESO-566: Reject arg overrides with an empty flag name

[bharath-b-rh]

Summary

Follow-up to #175: reject malformed tokens with an empty flag name (e.g. --=value, --=).

Previously these passed the -- prefix check, argFlagKey returned "--", and mergeContainerArgs could append the invalid arg to the operand Deployment instead of failing configuration validation (Degraded).

Changes

• parseOperandArgsEnv rejects tokens whose argFlagKey is "--"
• Unit coverage for --=value, --=, mid-list cases, and apply-path non-mutation

Test plan

• go test ./pkg/controller/external_secrets/ -count=1 -run 'TestParseOperandArgsEnv|TestApplyOperandArgsFromEnv'
• Confirm --=value in OPERAND_*_ARGS marks ExternalSecretsConfig Degraded and does not mutate operand args

[openshift-ci-robot]

@bharath-b-rh: This pull request references ESO-566 which is a valid jira issue.

Details

In response to this:

Summary

Follow-up to #175: reject malformed tokens with an empty flag name (e.g. --=value, --=).

Previously these passed the -- prefix check, argFlagKey returned "--", and mergeContainerArgs could append the invalid arg to the operand Deployment instead of failing configuration validation (Degraded).

Changes

• parseOperandArgsEnv rejects tokens whose argFlagKey is "--"
• Unit coverage for --=value, --=, mid-list cases, and apply-path non-mutation

Test plan

• go test ./pkg/controller/external_secrets/ -count=1 -run 'TestParseOperandArgsEnv|TestApplyOperandArgsFromEnv'
• Confirm --=value in OPERAND_*_ARGS marks ExternalSecretsConfig Degraded and does not mutate operand args

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 86a313c2-7b54-4a38-8944-2a6576aa85e4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-b-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bharath-b-rh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@bharath-b-rh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mytreya-rh]

/lgtm

[bharath-b-rh]

PR is for an additional misconfiguration scenario, which is vetted in e2e and UTs. Adding all required labels
/label docs-approved
/label qe-approved
/label px-approved