OLS-3822: Remove inline ExecutionVerification from execution output

[blublinsky]

Remove the ExecutionVerification type and all inline verification plumbing from the execution agent output. Execution executes; verification verifies — the inline verification added conceptual confusion (two things called "verification" at different layers) and has no meaningful consumer now that the verification agent has full retry autonomy (OLS-3781) and execution retries are removed (OLS-3793).

What's removed:

ExecutionVerification struct and ConditionOutcome type + constants from the API
verification field from ExecutionResultStatus (CRD field removal — see migration note)
verification object from the execution output schema (LLM no longer asked to produce it)
Inline verification forwarding from execution → verification agent context
Verification.Summary fallback in executionFailureMessage()
One test (VerifyExecWithoutInlineVerification) and related fixtures/assertions

What's kept:

"verification" in isObservationAction() for backward compatibility with existing execution results that may report a verification action type

[openshift-ci-robot]

@blublinsky: This pull request references OLS-3822 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Remove the ExecutionVerification type and all inline verification plumbing from the execution agent output. Execution executes; verification verifies — the inline verification added conceptual confusion (two things called "verification" at different layers) and has no meaningful consumer now that the verification agent has full retry autonomy (OLS-3781) and execution retries are removed (OLS-3793).

What's removed:

ExecutionVerification struct and ConditionOutcome type + constants from the API
verification field from ExecutionResultStatus (CRD field removal — see migration note)
verification object from the execution output schema (LLM no longer asked to produce it)
Inline verification forwarding from execution → verification agent context
Verification.Summary fallback in executionFailureMessage()
One test (VerifyExecWithoutInlineVerification) and related fixtures/assertions

What's kept:

"verification" in isObservationAction() for backward compatibility with existing execution results that may report a verification action type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Warning

Review limit reached

@blublinsky, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 10 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e0401dd6-0f58-4b52-a7ff-3f7de2fa7f49

📥 Commits

Reviewing files that changed from the base of the PR and between 303f265 and 6f56b89.

⛔ Files ignored due to path filters (2)

• api/v1alpha1/zz_generated.deepcopy.go is excluded by !**/zz_generated.deepcopy.go
• config/crd/bases/agentic.openshift.io_executionresults.yaml is excluded by !config/crd/bases/**

📒 Files selected for processing (15)

• .ai/spec/what/run-lifecycle.md
• .ai/spec/what/sandbox-execution.md
• api/v1alpha1/agenticrun_status_types.go
• api/v1alpha1/executionresult_types.go
• controller/agenticrun/agent.go
• controller/agenticrun/client.go
• controller/agenticrun/client_test.go
• controller/agenticrun/handlers.go
• controller/agenticrun/handlers_test.go
• controller/agenticrun/reconciler_test.go
• controller/agenticrun/results.go
• controller/agenticrun/sandbox_agent.go
• controller/agenticrun/sandbox_agent_test.go
• controller/agenticrun/schemas.go
• test/agent/main.go

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign blublinsky for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@blublinsky: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.