OCPBUGS-111603: force freerun when non-leading DPLL loses lock

[vitus133]

In chained-NIC T-GM/T-BC topologies, a non-leading DPLL losing lock must degrade the composite clock to FREERUN (S0). Previously the clock incorrectly reported HOLDOVER (S1) because:

1. UpdateState() gave HOLDOVER priority over FREERUN
2. The event package had no leading vs non-leading DPLL awareness.
3. stateDecision() used source-specific branches (GNSS/PPS/PTP4l) that don't reflect actual topology in multi-NIC configs. Changes:

• Fix UpdateState() priority (stats.go)
• Add hasNonLeadingDPLLFault() to detect follower faults when the leading DPLL is still locked (event.go)
• Apply to both T-GM (updateGMState) and T-BC (updateBCState) paths
• Refactor stateDecision() HOLDOVER branch: unify GNSS/PTP4l under hasLeadingSource(), non-leading DPLLs go directly to FREERUN
• Add leader-follower matrix state tests (stats_test.go)

[openshift-ci-robot]

@vitus133: This pull request references Jira Issue OCPBUGS-111603, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

In chained-NIC T-GM/T-BC topologies, a non-leading DPLL losing lock must degrade the composite clock to FREERUN (S0). Previously the clock incorrectly reported HOLDOVER (S1) because:

1. UpdateState() gave HOLDOVER priority over FREERUN
2. The event package had no leading vs non-leading DPLL awareness.
3. stateDecision() used source-specific branches (GNSS/PPS/PTP4l) that don't reflect actual topology in multi-NIC configs. Changes:

• Fix UpdateState() priority (stats.go)
• Add hasNonLeadingDPLLFault() to detect follower faults when the leading DPLL is still locked (event.go)
• Apply to both T-GM (updateGMState) and T-BC (updateBCState) paths
• Refactor stateDecision() HOLDOVER branch: unify GNSS/PTP4l under hasLeadingSource(), non-leading DPLLs go directly to FREERUN
• Add leader-follower matrix state tests (stats_test.go)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [vitus133]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vitus133]

/jira refresh

[openshift-ci-robot]

@vitus133: This pull request references Jira Issue OCPBUGS-111603, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-93744 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-93744 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (hhassid@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vitus133]

/labelbackport-risk-assessed
/verified later @hhassid

[openshift-ci-robot]

@vitus133: This PR has been marked to be verified later by @hhassid.

Details

In response to this:

/labelbackport-risk-assessed
/verified later @hhassid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@vitus133: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.