OCPBUGS-111584: Calibrate delays on XR8720t A00 - #635
Conversation
|
@vitus133: This pull request references Jira Issue OCPBUGS-111584, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vitus133 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Kernel nla_put_sint encodes fractional-frequency-offset(-ppt) with variable width; Int32 decoding aborted pin dumps when PPT arrived as 8 bytes. Co-authored-by: Cursor <cursoragent@cursor.com>
|
/jira refresh |
|
@vitus133: This pull request references Jira Issue OCPBUGS-111584, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (bblock@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label backport-risk-assessed |
|
@vitus133: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@vitus133: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Backport of upstream fix for OCPBUGS-98473 to release-4.22.
Dell XR8720t A0 PTP delays were not correctly calibrated: the DPLL phase-in delay compensation for
ETH01_SDP_TIMESYNC_2/ETH01_SDP_TIMESYNC_0was set to-5000ps instead of the correct-8600ps (calibrated on Calnex Neo).Cherry-picked commits
From k8snetworkplumbingwg/linuxptp-daemon#243 (merged downstream via #628):
56565ad0"Calibrate delays on XR8720t A00" — the actual bug fix (delays.yaml)00d28175"Reduce log noise" — downgrades severalglog.Infof/glog.Infocalls toglog.V(14)6ddba26d"Decode DPLL FFO sint attributes as 4- or 8-byte values" — fixes DPLL fractional-frequency-offset decoding that could abort pin dumpsNot backported:
eadc9073"Log DPLL pin tables only on lock-status change" depends on a prerequisite commit (d1756b6a, "dump DPLL pin states on source lock transitions") that introduced thenl.LogPinTablecall innlUpdateState. That prerequisite is not present onrelease-4.22, soeadc9073's diff has nothing to apply to on this branch (no-op / dead code). Skipped by agreement.Note:
00d28175had a merge conflict inpkg/event/event_tbc.gobecause two of its target log lines (isSourceLostBC[%s],DPLL detail: ...) don't exist inrelease-4.22's version ofisSourceLostBC(added by a separate, un-backported commit on main). Those hunks were dropped since there's nothing to reduce; the rest of the commit (converging onglog.V(14)for existing log lines inupdateBCState,convergeConfig, andptpdev.go) applied normally.Verification
Verify on target hardware:
Expected pin delays:
Jira: https://redhat.atlassian.net/browse/OCPBUGS-111584