OCPBUGS-105407: Remove VSphereMultiNetworks feature gate from e2e test

[vr4manta]

OCPBUGS-105407

Changes

• Removed VSphereMultiNetworks feature gate from e2e test

Notes

The VSphereMultiNetworks feature has been GA for several releases. Remove the OCPFeatureGate tag so the multi-NIC e2e test runs unconditionally.

Summary by CodeRabbit

• Tests
  • Updated the vSphere multi-network end-to-end test classification to use the standard managed-cluster description.
  • Existing vSphere platform and conformance coverage remains unchanged.
  • No user-facing functionality or product behavior changes are included in this update.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@vr4manta: This pull request references Jira Issue OCPBUGS-105407, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

OCPBUGS-105407

Changes

• Removed VSphereMultiNetworks feature gate from e2e test

Notes

The VSphereMultiNetworks feature has been GA for several releases. Remove the OCPFeatureGate tag so the multi-NIC e2e test runs unconditionally.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 757a83ea-fc92-4bca-8c15-e51b2cb72d04

📥 Commits

Reviewing files that changed from the base of the PR and between 0db39ee and aef1aaf.

📒 Files selected for processing (1)

• test/e2e/vsphere/multi-nic.go

---

Walkthrough

The VSphere multi-NIC e2e suite description removes the OCPFeatureGate:VSphereMultiNetworks label. It retains the cluster lifecycle, VSphere platform, and conformance labels.

Changes

VSphere multi-NIC test labeling

Layer / File(s)	Summary
Update multi-NIC suite labels test/e2e/vsphere/multi-nic.go	The Ginkgo suite description removes the VSphereMultiNetworks feature-gate label and preserves the other suite labels.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 13 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Test Structure And Quality	⚠️ Warning	multi-nic.go has many bare Expect(err).NotTo(HaveOccurred()) assertions, including setup and cluster checks, so failures lack the required diagnostic messages.	Add meaningful context messages to each assertion, such as the operation and resource involved; use AfterEach for reliable scale-down cleanup if validation fails.
Single Node Openshift (Sno) Test Compatibility	⚠️ Warning	Removing the feature gate newly enables an unguarded serial test that scales a MachineSet up and down; this is an explicit multi-node assumption and no SNO guard exists.	Run /payload-job periodic-ci-openshift-release-master-nightly-4.22-e2e-aws-ovn-single-node-serial. If unsupported, add [Skipped:SingleReplicaTopology] or a topology skip guard.

✅ Passed checks (13 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the removal of the VSphereMultiNetworks feature gate from the vSphere multi-NIC end-to-end test.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only a static Describe label, and all Describe/It titles in the file use fixed string literals without generated values, node names, namespaces, IPs, or timestamps.
Microshift Test Compatibility	✅ Passed	The PR only removes a Describe feature-gate tag; it adds no tests, and all five existing Its carry [apigroup:machine.openshift.io], which MicroShift CI skips.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR changes only a Ginkgo label in test/e2e/vsphere/multi-nic.go; it adds no manifests, operators, controllers, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	OTE main calls logs.InitLogs; OTE config sends GinkgoWriter to stderr, and all fmt.Printf calls are in It-reached helpers captured by Ginkgo RunSpec.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only a Describe label; it adds no Ginkgo tests, IPv4 literals, or public-network access. Existing CIDR checks parse runtime cluster values and support IPv6.
No-Weak-Crypto	✅ Passed	The PR changes only the Ginkgo label in test/e2e/vsphere/multi-nic.go; the diff adds no weak-crypto API, custom crypto, or secret comparison.
Container-Privileges	✅ Passed	The PR changes only a Go test label; it adds no container/Kubernetes manifest and no privileged, host namespace, SYS_ADMIN, or privilege-escalation setting.
No-Sensitive-Data-In-Logs	✅ Passed	The diff changes only the Ginkgo description label; it adds no logging calls or sensitive values.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

_{Comment @coderabbitai help to get the list of available commands.}

[vr4manta]

/assign @damdo

[damdo]

/approve

/pipeline auto

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[damdo]

/pipeline required

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn

[vr4manta]

/verified by @vr4manta

[openshift-ci-robot]

@vr4manta: This PR has been marked as verified by @vr4manta.

Details

In response to this:

/verified by @vr4manta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jcpowermac]

/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 0db39ee and 2 for PR HEAD aef1aaf in total

[vr4manta]

/retest

[openshift-ci]

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@vr4manta: Jira Issue OCPBUGS-105407: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

• openshift/api#2975 is open

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-105407 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

OCPBUGS-105407

Changes

• Removed VSphereMultiNetworks feature gate from e2e test

Notes

The VSphereMultiNetworks feature has been GA for several releases. Remove the OCPFeatureGate tag so the multi-NIC e2e test runs unconditionally.

Summary by CodeRabbit

• Tests
• Updated the vSphere multi-network end-to-end test classification to use the standard managed-cluster description.
• Existing vSphere platform and conformance coverage remains unchanged.
• No user-facing functionality or product behavior changes are included in this update.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.