Skip to content

OSDOCS-16959-ldap-identity-sync CQA - #116487

Merged
mburke5678 merged 1 commit into
openshift:mainfrom
wgabor0427:OSDOCS-16959-ldap-identity-sync
Aug 12, 2026
Merged

OSDOCS-16959-ldap-identity-sync CQA#116487
mburke5678 merged 1 commit into
openshift:mainfrom
wgabor0427:OSDOCS-16959-ldap-identity-sync

Conversation

@wgabor0427

@wgabor0427 wgabor0427 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Version(s):
4.20+

Issue:
https://redhat.atlassian.net/browse/OSDOCS-16959

Link to docs preview:
https://116487--ocpdocs-pr.netlify.app/openshift-enterprise/latest/authentication/ldap-syncing.html

QE review:

  • QE has approved this change.

Additional information:
The ldap-syncing-nesting.adoc module had a large amount of text before the prerequisites. Because of that I put that text in a new module named ldap-syncing-nesting-about.adoc. None of the text changed it was just moved to this new module. Not sure if that requires a SME review or not.

@openshift-ci openshift-ci Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 24, 2026
Comment thread modules/ldap-syncing-about.adoc Outdated
Comment thread modules/ldap-syncing-config-rfc2307.adoc Outdated
Comment thread modules/ldap-syncing-rfc2307-user-defined.adoc
Comment thread modules/ldap-syncing-rfc2307.adoc
Comment thread modules/ldap-syncing-running.adoc Outdated
@wgabor0427
wgabor0427 force-pushed the OSDOCS-16959-ldap-identity-sync branch 2 times, most recently from 89b73be to 0e58041 Compare July 24, 2026 22:03
Comment thread modules/ldap-syncing-rfc2307-user-defined-error.adoc Outdated
@wgabor0427
wgabor0427 force-pushed the OSDOCS-16959-ldap-identity-sync branch from 0e58041 to 6e2453d Compare July 26, 2026 20:47
Comment thread modules/ldap-syncing-spec.adoc Outdated
Comment thread modules/ldap-syncing-spec.adoc
Comment thread modules/ldap-syncing-spec.adoc
@wgabor0427
wgabor0427 force-pushed the OSDOCS-16959-ldap-identity-sync branch from 6e2453d to 57035e6 Compare July 26, 2026 21:07
Comment thread modules/ldap-syncing-spec.adoc Outdated
@wgabor0427
wgabor0427 force-pushed the OSDOCS-16959-ldap-identity-sync branch 2 times, most recently from a3c2fea to cd9bcd5 Compare July 29, 2026 23:01
@openshift-ci openshift-ci Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 29, 2026
@wgabor0427
wgabor0427 force-pushed the OSDOCS-16959-ldap-identity-sync branch 9 times, most recently from e787006 to ca8b3c4 Compare August 3, 2026 19:48
Comment thread authentication/ldap-syncing.adoc Outdated
@openshift-ci openshift-ci Bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 11, 2026
@mburke5678 mburke5678 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 12, 2026
Comment thread modules/ldap-syncing-augmented-activedir.adoc Outdated
@wgabor0427
wgabor0427 force-pushed the OSDOCS-16959-ldap-identity-sync branch from 8f2ec82 to e5a8bc2 Compare August 12, 2026 19:31
Comment thread modules/ldap-syncing-running-subset.adoc Outdated
Comment thread modules/ldap-syncing-running-all-ldap.adoc Outdated
Comment thread modules/ldap-syncing-running-openshift.adoc Outdated
@mburke5678

Copy link
Copy Markdown
Contributor

@wgabor0427 A couple of copy/paste errors and we can knock this one down!

@wgabor0427

Copy link
Copy Markdown
Contributor Author

I fixed all of the ones in the other modules to match like the ones above

@wgabor0427
wgabor0427 force-pushed the OSDOCS-16959-ldap-identity-sync branch from e5a8bc2 to 8be1639 Compare August 12, 2026 19:55
@wgabor0427

Copy link
Copy Markdown
Contributor Author

/test validate-asciidoc

@openshift-ci

openshift-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown

@wgabor0427: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mburke5678 mburke5678 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 12, 2026
@mburke5678
mburke5678 merged commit 92c97b0 into openshift:main Aug 12, 2026
2 checks passed
@mburke5678

Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.20

@mburke5678

Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.21

@mburke5678

Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.22

@mburke5678

Copy link
Copy Markdown
Contributor

/cherrypick enterprise-5.0

@openshift-cherrypick-robot

Copy link
Copy Markdown

@mburke5678: new pull request created: #117889

Details

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@mburke5678: #116487 failed to apply on top of branch "enterprise-4.22":

Patch is empty.
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To record the empty patch as an empty commit, run "git am --allow-empty".
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

Details

In response to this:

/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@mburke5678: new pull request created: #117890

Details

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@mburke5678: new pull request created: #117891

Details

In response to this:

/cherrypick enterprise-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mburke5678

Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.22

@openshift-cherrypick-robot

Copy link
Copy Markdown

@mburke5678: new pull request created: #117892

Details

In response to this:

/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants