[OSDOCS-16999] IBM Cloud VPC CQA: style fixes, abstracts, Vale corrections - #117836
Conversation
openshift-ci
Bot
added
the
size/M
|
🤖 Fri Aug 14 14:45:31 - Prow CI generated the docs preview: |
56afa03 to
cb76ecd
Compare
openshift-ci
Bot
added
size/L
cb76ecd to
d367e2c
Compare
|
/label merge-review-needed |
openshift-ci
Bot
added
the
merge-review-needed
lahinson
added
merge-review-in-progress
lahinson
left a comment
lahinson
left a comment
There was a problem hiding this comment.
@SNiemann15 Just two tiny things to fix before this one can be merged. Thanks!
| [NOTE] | ||
| ==== | ||
| Make sure you have integrated Key Protect with your {ibm-cloud-title} Block Storage service. For more information, see the Key Protect link:https://cloud.ibm.com/docs/key-protect?topic=key-protect-integrate-services#grant-access[documentation]. | ||
| Make sure you have integrated Key Protect with your {ibm-cloud-title} Block Storage service. For more information, see the Additional resources section. |
There was a problem hiding this comment.
The OCP docs guidelines warn against mentioning the "Additional resources section": https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#lead-in-link-sentence-style-for-non-xref-situations
| 1. The policy access scope should be set based on how granular you want to assign access. The scope can be set to *All resources* or *Resources based on selected attributes*. | ||
| 2. Optional: This access policy is only required if you want the installation program to create a resource group. For more information about resource groups, see the "{ibm-name} resource groups documentation". | ||
| -- | ||
| + |
There was a problem hiding this comment.
| + |
Preview looks a bit off:
If you remove the +, I think that will fix it.
d367e2c to
703cb68
Compare
703cb68 to
7486101
Compare
|
@SNiemann15: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.20 |
|
@lahinson: new pull request created: #118071 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #118072 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #118073 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #118074 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
…tural changes)
Version(s): 4.20
Issue: https://redhat.atlassian.net/browse/OSDOCS-16999
Link to docs preview:
QE review:
Additional information: