CORENET-7431: Register network-tools OTE binary

[anuragthehatter]

Summary

• Add network-tools extension binary to the payload image registry in pkg/test/extensions/binary.go
• Enables openshift-tests to discover and run network-tools OTP test cases (55887, 55889, 67625, 67648, 67649)

Dependencies

• CORENET-7431: migrate OTP network-tools test cases network-tools#190

Test plan

• Verify go build ./... passes
• Run /testwith openshift/network-tools#190 to validate end-to-end

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features
  • Added the network-tools extension binary to the available extension registry.
  • Mapped the network tools image tag to its packaged test executable.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 34d441d5-b3b9-4465-8721-9180c8f28690

📥 Commits

Reviewing files that changed from the base of the PR and between 5cddf6d and 079459a.

📒 Files selected for processing (1)

• pkg/test/extensions/binary.go

---

Walkthrough

The extension registry now maps the network-tools image tag to /usr/bin/network-tools-tests-ext.gz.

Changes

Network tools extension

Layer / File(s)	Summary
Register network-tools binary pkg/test/extensions/binary.go	Adds the network-tools external test binary to extensionBinaries.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: ⚪ Minimal · up to 07945

This localized change only registers the network-tools test binary. No actionable merge-blocking risk remains after the planned normal verification checks.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Single Node Openshift (Sno) Test Compatibility	⚠️ Warning	The new registry entry enables upstream Ginkgo test 67625-67648, which requires two ready nodes and pins pods to distinct nodes; it has no accepted SNO guard.	Add [Skipped:SingleReplicaTopology] or an exutil.IsSingleNode()/topology guard, or verify with /payload-job periodic-ci-openshift-release-master-ci-4.22-e2e-aws-upgrade-ovn-single-node.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The exact PR diff adds only a static imageTag and binaryPath registry entry; it adds no Ginkgo test title or dynamic test-name value.
Test Structure And Quality	✅ Passed	The PR changes only four registry lines in pkg/test/extensions/binary.go; it adds no Ginkgo It blocks or cluster operations subject to this check.
Microshift Test Compatibility	✅ Passed	The diff adds only a network-tools binary registry entry; it adds no Ginkgo tests or MicroShift-incompatible API and feature references.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit changes only the extension binary registry in pkg/test/extensions/binary.go; it adds no deployment manifests, operators, controllers, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The diff adds only imageTag and binaryPath literals; it adds no process-level stdout write or OTE binary source change. Existing logging is unchanged.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff changes only the extension registry in binary.go. It adds no Ginkgo tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto	✅ Passed	The PR adds only a network-tools image-to-binary registry entry; the diff introduces no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret-comparison code.
Container-Privileges	✅ Passed	The commit only adds a network-tools binary registry entry; it adds no container/Kubernetes manifest or privilege-related field.
No-Sensitive-Data-In-Logs	✅ Passed	The PR adds only a registry image tag and binary path. It adds no logging or sensitive values, and the file has the same 60 logging-call matches as its parent.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the registration of the network-tools OTE binary, which is the main change in the pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anuragthehatter
Once this PR has been reviewed and has the lgtm label, please assign smg247 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@anuragthehatter: This pull request references CORENET-7431 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

• Add network-tools extension binary to the payload image registry in pkg/test/extensions/binary.go
• Enables openshift-tests to discover and run network-tools OTP test cases (55887, 55889, 67625, 67648, 67649)

Dependencies

• CORENET-7431: migrate OTP network-tools test cases network-tools#190

Test plan

• Verify go build ./... passes
• Run /testwith openshift/network-tools#190 to validate end-to-end

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features
• Added the network-tools extension binary to the available extension registry.
• Mapped the network tools image tag to its packaged test executable.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@anuragthehatter: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn-upi	079459a	link	true	/test e2e-vsphere-ovn-upi
ci/prow/e2e-aws-ovn-microshift	079459a	link	true	/test e2e-aws-ovn-microshift
ci/prow/e2e-aws-ovn-serial-2of2	079459a	link	true	/test e2e-aws-ovn-serial-2of2
ci/prow/e2e-aws-ovn-serial-1of2	079459a	link	true	/test e2e-aws-ovn-serial-1of2
ci/prow/e2e-gcp-ovn	079459a	link	true	/test e2e-gcp-ovn
ci/prow/e2e-aws-csi	079459a	link	true	/test e2e-aws-csi
ci/prow/e2e-aws-ovn-fips	079459a	link	true	/test e2e-aws-ovn-fips
ci/prow/e2e-vsphere-ovn	079459a	link	true	/test e2e-vsphere-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6	079459a	link	true	/test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp-ovn-upgrade	079459a	link	true	/test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-microshift-serial	079459a	link	true	/test e2e-aws-ovn-microshift-serial
ci/prow/e2e-gcp-csi	079459a	link	true	/test e2e-gcp-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.