[DO NOT MERGE] DEBUG - #72102
Conversation
openshift-ci
Bot
added
the
do-not-merge/hold
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-azure-ipi-confidential-trustedlaunch-f28-destructive |
|
@sergiordlr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lifecycle frozen |
|
@sergiordlr: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/uncc |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-baremetalds-ipi-ovn-ipv4-fips-f28-destructive |
|
@sergiordlr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@sergiordlr: job(s): periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-baremetalds-ipi-ovn-ipv4-fips-f28-destructive either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-azure-ipi-confidential-trustedlaunch-f28-destructive |
|
@sergiordlr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-arm64-nightly-aws-ipi-longrun-mco-tp-proxy-fips-p3-f28 |
|
@sergiordlr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-arm64-nightly-aws-ipi-longrun-mco-tp-proxy-fips-p3-f28 |
|
@sergiordlr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-arm64-nightly-aws-ipi-longrun-mco-tp-proxy-fips-p3-f28 |
|
@sergiordlr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-aws-ipi-longduration-mco-p1-f7 |
|
@sergiordlr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-vsphere-ipi-longduration-mco-fips-proxy-g1-f14 |
|
@sergiordlr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-vsphere-ipi-longduration-mco-fips-proxy-g2-f14 |
|
@sergiordlr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-aws-ipi-localzone-fips-mini-perm-f28-destructive |
|
@sergiordlr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-arm64-nightly-aws-ipi-longrun-mco-tp-proxy-fips-p3-f28 |
|
@sergiordlr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sergiordlr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-vsphere-ipi-multi-vcenter-f28 |
|
@sergiordlr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
ci-operator/step-registry/openshift-extended/test/openshift-extended-test-commands.sh (1)
7-9: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse the required shell safety baseline.
The script enables
errexitandpipefail, but it does not enablenounset. Useset -euo pipefailbefore this new block. Verify that variables used later, includingARTIFACT_DIR, are initialized.Proposed fix
-set -o errexit -set -o pipefail +set -euo pipefailAs per coding guidelines, step-registry command scripts must default to
set -euo pipefailwithout-x.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/step-registry/openshift-extended/test/openshift-extended-test-commands.sh` around lines 7 - 9, Update the shell safety setup in the openshift-extended test command script to use set -euo pipefail before the new block, preserving the required no-tracing default. Ensure variables referenced later, including ARTIFACT_DIR, are initialized before use.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/cucushift/upgrade/toimage/cucushift-upgrade-toimage-commands.sh`:
- Around line 672-676: Gate the debug pause around the visible “WAITING FOR
DEBUG” loop behind an explicit debug variable, such as the repository’s
established debug flag, so normal CI execution proceeds without waiting for
/tmp/continue. If the debug path remains enabled, add a bounded timeout;
otherwise remove the pause before merging to main.
In
`@ci-operator/step-registry/ipi/install/install/ipi-install-install-commands.sh`:
- Around line 915-922: Update the non-zero ret handling around the debug wait to
prevent indefinite blocking: only enter the /tmp/continue polling loop when an
explicit debug-mode control is enabled, or enforce a finite timeout before
proceeding. Preserve reporting the original install failure and ensure normal CI
completes without waiting forever.
---
Nitpick comments:
In
`@ci-operator/step-registry/openshift-extended/test/openshift-extended-test-commands.sh`:
- Around line 7-9: Update the shell safety setup in the openshift-extended test
command script to use set -euo pipefail before the new block, preserving the
required no-tracing default. Ensure variables referenced later, including
ARTIFACT_DIR, are initialized before use.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 92a0e674-7443-4d04-bcb1-c7cc2854daf1
⛔ Files ignored due to path filters (5)
ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.20-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.20-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.21-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.22-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (22)
ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.20__periodics.yamlci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.21__periodics.yamlci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.22__periodics.yamlci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0__periodics.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__arm64-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yamlci-operator/step-registry/baremetalds/e2e/test/baremetalds-e2e-test-commands.shci-operator/step-registry/cucushift/installer/rehearse/vsphere/ipi/disc-proxy/OWNERSci-operator/step-registry/cucushift/installer/rehearse/vsphere/ipi/disc-proxy/cucushift-installer-rehearse-vsphere-ipi-disc-proxy-workflow.metadata.jsonci-operator/step-registry/cucushift/installer/rehearse/vsphere/ipi/disc-proxy/cucushift-installer-rehearse-vsphere-ipi-disc-proxy-workflow.yamlci-operator/step-registry/cucushift/installer/rehearse/vsphere/ipi/disc-proxy/provision/OWNERSci-operator/step-registry/cucushift/installer/rehearse/vsphere/ipi/disc-proxy/provision/cucushift-installer-rehearse-vsphere-ipi-disc-proxy-provision-chain.metadata.jsonci-operator/step-registry/cucushift/installer/rehearse/vsphere/ipi/disc-proxy/provision/cucushift-installer-rehearse-vsphere-ipi-disc-proxy-provision-chain.yamlci-operator/step-registry/cucushift/upgrade/toimage/cucushift-upgrade-toimage-commands.shci-operator/step-registry/ipi/install/install/ipi-install-install-commands.shci-operator/step-registry/mco/check/day1-enable-ocl/mco-check-day1-enable-ocl-commands.shci-operator/step-registry/mco/conf/day2/add-mcoqe-robot-to-pull-secret/mco-conf-day2-add-mcoqe-robot-to-pull-secret-ref.yamlci-operator/step-registry/openshift-extended/test/disruptive/openshift-extended-test-disruptive-commands.shci-operator/step-registry/openshift-extended/test/longduration/openshift-extended-test-longduration-commands.shci-operator/step-registry/openshift-extended/test/openshift-extended-test-commands.shci-operator/step-registry/openshift/e2e/test/openshift-e2e-test-commands.sh
💤 Files with no reviewable changes (1)
- ci-operator/step-registry/mco/conf/day2/add-mcoqe-robot-to-pull-secret/mco-conf-day2-add-mcoqe-robot-to-pull-secret-ref.yaml
🚧 Files skipped from review as they are similar to previous changes (4)
- ci-operator/step-registry/openshift-extended/test/longduration/openshift-extended-test-longduration-commands.sh
- ci-operator/step-registry/openshift/e2e/test/openshift-e2e-test-commands.sh
- ci-operator/step-registry/openshift-extended/test/disruptive/openshift-extended-test-disruptive-commands.sh
- ci-operator/step-registry/baremetalds/e2e/test/baremetalds-e2e-test-commands.sh
| echo "WAITING FOR DEBUG..." | ||
| while [ ! -f "/tmp/continue" ] | ||
| do | ||
| sleep 10 | ||
| done |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Gate the debug wait before merge.
Lines 672-676 block every invocation until /tmp/continue exists. A normal CI job that does not create this marker cannot complete and will consume the job timeout. Gate the wait behind an explicit debug variable. Add a bounded timeout, or remove the block before merging to main.
Suggested guard
-echo "WAITING FOR DEBUG..."
-while [ ! -f "/tmp/continue" ]
-do
- sleep 10
-done
+if [[ "${DEBUG_WAIT:-false}" == "true" ]]; then
+ echo "WAITING FOR DEBUG..."
+ while [[ ! -f "/tmp/continue" ]]; do
+ sleep 10
+ done
+fiBased on the PR objective, this block is intended for debug-only CI pauses.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| echo "WAITING FOR DEBUG..." | |
| while [ ! -f "/tmp/continue" ] | |
| do | |
| sleep 10 | |
| done | |
| if [[ "${DEBUG_WAIT:-false}" == "true" ]]; then | |
| echo "WAITING FOR DEBUG..." | |
| while [[ ! -f "/tmp/continue" ]]; do | |
| sleep 10 | |
| done | |
| fi |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/step-registry/cucushift/upgrade/toimage/cucushift-upgrade-toimage-commands.sh`
around lines 672 - 676, Gate the debug pause around the visible “WAITING FOR
DEBUG” loop behind an explicit debug variable, such as the repository’s
established debug flag, so normal CI execution proceeds without waiting for
/tmp/continue. If the debug path remains enabled, add a bounded timeout;
otherwise remove the pause before merging to main.
| if test "${ret}" -ne 0 ; then | ||
| echo "Install failed with exit code ${ret}, waiting for debug..." | ||
| export PATH=/tmp/:$PATH | ||
| while [ ! -f "/tmp/continue" ] | ||
| do | ||
| sleep 10 | ||
| done | ||
| fi |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Bound or gate the debug wait.
When ret is non-zero, Lines 918-921 sleep indefinitely until /tmp/continue appears. A routine install failure can therefore leave the CI job active forever and consume an executor instead of completing with the original failure. Gate this loop behind an explicit debug-only control or add a finite timeout before merging this step into normal CI.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/step-registry/ipi/install/install/ipi-install-install-commands.sh`
around lines 915 - 922, Update the non-zero ret handling around the debug wait
to prevent indefinite blocking: only enter the /tmp/continue polling loop when
an explicit debug-mode control is enabled, or enforce a finite timeout before
proceeding. Preserve reporting the original install failure and ensure normal CI
completes without waiting forever.
openshift-ci
Bot
added
the
needs-rebase
|
/pj-rehearse periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-vsphere-mco-tp-longduration-1of2 |
|
@sergiordlr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@sergiordlr, |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
openshift-ci
Bot
removed
the
needs-rebase
|
/pj-rehearse periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-vsphere-mco-tp-longduration-1of2 periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-aws-mco-fips-proxy-longduration-2of3 |
|
@sergiordlr: your |
|
[REHEARSALNOTIFIER]
A total of 39301 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/test config |
|
/pj-rehearse periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-vsphere-mco-tp-longduration-1of2 periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-aws-mco-fips-proxy-longduration-2of3 |
|
@sergiordlr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-vsphere-mco-tp-longduration-1of2 periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-aws-mco-fips-proxy-longduration-2of3 |
|
@sergiordlr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@sergiordlr: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
/hold
Summary by CodeRabbit
CI debugging
/tmp/continuepause points to OpenShift test, installation, upgrade, and MCO verification scripts.vSphere CI coverage
Configuration
cli: latestfrom the MCO pull-secret step configuration.