test: dont merge: testrelease branch - #82946
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe change adds a MetalLB OpenShift test-release configuration and allows callers to override the MetalLB repository and MetalLB and FRR-K8s branches. ChangesMetalLB OpenShift test release
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ajaggapa
changed the title
|
@ajaggapa, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Adds pre-merge CI with metallb-e2e-metal test using the baremetalds-metallb-e2e workflow on equinix-ocp-metal. Co-authored-by: Cursor <cursoragent@cursor.com>
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/ajaggapa/metallb-openshift/ajaggapa-metallb-testrelease.yaml`:
- Around line 37-54: Update zz_generated_metadata.repo from metallb to
metallb-openshift, then run make update to regenerate the metadata and Prow job
configuration; do not edit generated metadata manually beyond the source
correction.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 7a56e951-1803-406e-8559-e019dc479268
⛔ Files ignored due to path filters (2)
ci-operator/jobs/ajaggapa/metallb-openshift/ajaggapa-metallb-openshift-ajaggapa-metallb-testrelease-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/ajaggapa/metallb-openshift/ajaggapa-metallb-openshift-ajaggapa-metallb-testrelease-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/ajaggapa/metallb-openshift/ajaggapa-metallb-testrelease.yaml
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Co-authored-by: Cursor <cursoragent@cursor.com>
|
/pj-rehearse pull-ci-ajaggapa-metallb-openshift-ajaggapa-metallb-testrelease-metallb-e2e-metal |
|
@ajaggapa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Rename ajaggapa-metallb-testrelease.yaml to ajaggapa-metallb-openshift-testrelease.yaml so prowgen correctly derives branch=testrelease for the presubmit jobs. Co-authored-by: Cursor <cursoragent@cursor.com>
|
/pj-rehearse pull-ci-ajaggapa-metallb-openshift-ajaggapa-metallb-testrelease-metallb-e2e-metal |
|
@ajaggapa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@ajaggapa: job(s): pull-ci-ajaggapa-metallb-openshift-ajaggapa-metallb-testrelease-metallb-e2e-metal either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-ajaggapa-metallb-openshift-ajaggapa-metallb-testrelease-metallb-e2e-metal |
1 similar comment
|
/pj-rehearse pull-ci-ajaggapa-metallb-openshift-ajaggapa-metallb-testrelease-metallb-e2e-metal |
|
@ajaggapa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 similar comment
|
@ajaggapa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@ajaggapa: job(s): pull-ci-ajaggapa-metallb-openshift-ajaggapa-metallb-testrelease-metallb-e2e-metal either don't exist or were not found to be affected, and cannot be rehearsed |
1 similar comment
|
@ajaggapa: job(s): pull-ci-ajaggapa-metallb-openshift-ajaggapa-metallb-testrelease-metallb-e2e-metal either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-ajaggapa-metallb-openshift-testrelease-metallb-e2e-metal |
|
@ajaggapa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-ajaggapa-metallb-openshift-testrelease-metallb-e2e-metal |
|
/pj-rehearse pull-ci-ajaggapa-metallb-openshift-ajaggapa-metallb-testrelease-metallb-e2e-metal |
|
@ajaggapa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-ajaggapa-metallb-openshift-testrelease-metallb-e2e-metal |
|
@ajaggapa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 similar comment
|
@ajaggapa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@ajaggapa: job(s): pull-ci-ajaggapa-metallb-openshift-ajaggapa-metallb-testrelease-metallb-e2e-metal either don't exist or were not found to be affected, and cannot be rehearsed |
Set METALLB_REPO env var so the metallb e2e test step clones from the fork instead of upstream openshift/metallb. Co-authored-by: Cursor <cursoragent@cursor.com>
Make METALLB_BRANCH and FRRK8S_BRANCH overridable via env vars (backward compatible - defaults to OC_BRANCH as before). Set METALLB_BRANCH=testrelease to use the fork's branch. Co-authored-by: Cursor <cursoragent@cursor.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ajaggapa The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
removed
the
approved
…step Co-authored-by: Cursor <cursoragent@cursor.com>
|
/pj-rehearse pull-ci-ajaggapa-metallb-openshift-ajaggapa-metallb-testrelease-metallb-e2e-metal |
|
@ajaggapa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@ajaggapa: job(s): pull-ci-ajaggapa-metallb-openshift-ajaggapa-metallb-testrelease-metallb-e2e-metal either don't exist or were not found to be affected, and cannot be rehearsed |
Co-authored-by: Cursor <cursoragent@cursor.com>
|
[REHEARSALNOTIFIER]
A total of 103 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@ajaggapa: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary
ajaggapa/metallb-openshifton thetestreleasebranchmetallb-e2e-metalpresubmit test usingbaremetalds-metallb-e2eworkflow onequinix-ocp-metalcluster profileSummary by CodeRabbit
ajaggapa/metallb-openshifton thetestreleasebranch.metallb-e2e-metalpresubmit test with thebaremetalds-metallb-e2eworkflow onequinix-ocp-metal.METALLB_BRANCHandFRRK8S_BRANCHdefaults to the cluster’sOC_BRANCH.