e2e-rosa-hcp-ovn: remove TEST_SKIPS overrides from nightly configs (4.22/5.0/5.1)

[dustman9000]

Remove TEST_SKIPS env overrides from the e2e-rosa-hcp-ovn test in the 4.22, 5.0, and 5.1 nightly configs. The rosa-aws-hcp-conformance workflow now owns the full skip list.

Why this matters

In ci-operator, test-level env overrides completely replace workflow-level env (no merging). So every time a new test needed skipping on HCP conformance, we had to:

1. Edit a TRT-owned nightly config file
2. Get TRT approval
3. Do this separately for each version

Now that the workflow is the source of truth, ROSA CI can manage the skip list independently via the ROSA-owned step registry files.

Ordering

This depends on #83478 being merged first. That PR adds all patterns from the per-version overrides into the workflow so nothing is lost when these overrides are removed.

Changes

• openshift-release-main__nightly-4.22.yaml: removed TEST_SKIPS from e2e-rosa-hcp-ovn
• openshift-release-main__nightly-5.0.yaml: removed TEST_SKIPS from e2e-rosa-hcp-ovn
• openshift-release-main__nightly-5.1.yaml: removed TEST_SKIPS from e2e-rosa-hcp-ovn

/cc @openshift/openshift-team-rosa @openshift/test-platform

Summary by CodeRabbit

• Removes version-specific TEST_SKIPS overrides from the e2e-rosa-hcp-ovn jobs in the 4.22, 5.0, and 5.1 nightly OpenShift CI configurations.
• Delegates the complete HCP conformance skip list to the rosa-aws-hcp-conformance workflow.
• Allows ROSA CI to manage skip patterns through ROSA-owned step registry files.

[openshift-ci]

@dustman9000: GitHub didn't allow me to request PR reviews from the following users: openshift/openshift-team-rosa.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Remove TEST_SKIPS env overrides from the e2e-rosa-hcp-ovn test in the 4.22, 5.0, and 5.1 nightly configs. The rosa-aws-hcp-conformance workflow now owns the full skip list.

Why this matters

In ci-operator, test-level env overrides completely replace workflow-level env (no merging). So every time a new test needed skipping on HCP conformance, we had to:

1. Edit a TRT-owned nightly config file
2. Get TRT approval
3. Do this separately for each version

Now that the workflow is the source of truth, ROSA CI can manage the skip list independently via the ROSA-owned step registry files.

Ordering

This depends on #83478 being merged first. That PR adds all patterns from the per-version overrides into the workflow so nothing is lost when these overrides are removed.

Changes

• openshift-release-main__nightly-4.22.yaml: removed TEST_SKIPS from e2e-rosa-hcp-ovn
• openshift-release-main__nightly-5.0.yaml: removed TEST_SKIPS from e2e-rosa-hcp-ovn
• openshift-release-main__nightly-5.1.yaml: removed TEST_SKIPS from e2e-rosa-hcp-ovn

/cc @openshift/openshift-team-rosa @openshift/test-platform

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d6e05609-ed7a-4d0f-a1af-df556cdef467

📥 Commits

Reviewing files that changed from the base of the PR and between 1ef5a7f and ca4a4e3.

📒 Files selected for processing (3)

• ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml
• ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
• ci-operator/config/openshift/release/openshift-release-main__nightly-5.1.yaml

💤 Files with no reviewable changes (3)

• ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
• ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml
• ci-operator/config/openshift/release/openshift-release-main__nightly-5.1.yaml

---

Walkthrough

The nightly e2e-rosa-hcp-ovn jobs no longer define TEST_SKIPS exclusions in the 4.22 and 5.1 release configurations. Their other job settings remain unchanged.

Changes

ROSA HCP test configuration

Layer / File(s)	Summary
Remove nightly test exclusions ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml, ci-operator/config/openshift/release/openshift-release-main__nightly-5.1.yaml	Removed the TEST_SKIPS lists from the e2e-rosa-hcp-ovn jobs. Existing schedules, environments, observers, and workflows remain unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to ca4a4

This change removes redundant TEST_SKIPS overrides from the 4.22, 5.0, and 5.1 nightly configurations so the workflow owns the skip list; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

• openshift/release#83474: Reverses related TEST_SKIPS additions in the ROSA HCP configuration.
• openshift/release#83478: Centralizes related ROSA HCP TEST_SKIPS behavior in the shared workflow.
• openshift/release#83479: Adds specific flaky-test skips for ROSA HCP conformance jobs.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the test, the removed TEST_SKIPS overrides, and the affected nightly configurations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request changes only YAML TEST_SKIPS overrides and does not add or modify Ginkgo test titles.
Test Structure And Quality	✅ Passed	The commit only deletes TEST_SKIPS entries from three YAML ci-operator configs; it adds no Ginkgo tests, setup, waits, or assertions covered by this check.
Microshift Test Compatibility	✅ Passed	The commit changes only three YAML files and removes TEST_SKIPS from ROSA workflow jobs; it adds no Ginkgo tests or MicroShift-incompatible test code.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The diff only removes TEST_SKIPS from three YAML jobs; it adds no Ginkgo tests or multi-node test assumptions. The workflow retains its existing HCP conformance setup.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit changes only three ci-operator nightly YAML test entries by removing TEST_SKIPS; it adds no deployment, operator, controller, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The diff changes only three YAML configs by removing TEST_SKIPS; it adds no OTE process-level code or stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only three YAML files and deletes TEST_SKIPS entries; it adds no Ginkgo tests or IPv4 or external-connectivity code.
No-Weak-Crypto	✅ Passed	The PR only deletes TEST_SKIPS entries from three YAML jobs. It adds no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret-comparison code.
Container-Privileges	✅ Passed	The diff only removes TEST_SKIPS from three CI YAML test environments; no added privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings appear.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only deletes TEST_SKIPS lines from three YAML jobs; the diff has zero added lines and introduces no logging or sensitive-data output.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@dustman9000: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-release-main-nightly-4.22-e2e-rosa-hcp-ovn	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-release-main-nightly-5.1-e2e-rosa-hcp-ovn	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-rosa-hcp-ovn	N/A	periodic	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@dustman9000: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[neisw]

/approve

[dustman9000]

/pj-rehearse ack

[openshift-merge-bot]

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jfrazierRedHat]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000, jfrazierRedHat, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/release/OWNERS [neisw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment