Add CNO secondary encap CI lanes for 4.20-4.22 and 5.0

[cgoncalves]

Mirror the existing master/5.1 optional metal IPI job so OVN encap override changes are covered on those release branches.

Summary by CodeRabbit

Adds optional OVN secondary encapsulation metal E2E CI lanes for the Cluster Network Operator release branches 4.20, 4.21, 4.22, and 5.0. The lanes use the cluster-network-operator-ovn-secondary-encap workflow and run only when relevant OVN or OVN-Kubernetes files change.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ac9a9544-c516-48d2-8297-d640b53722a0

📥 Commits

Reviewing files that changed from the base of the PR and between 932b442 and dee130a.

⛔ Files ignored due to path filters (4)

• ci-operator/jobs/openshift/cluster-network-operator/openshift-cluster-network-operator-release-4.20-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift/cluster-network-operator/openshift-cluster-network-operator-release-4.21-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift/cluster-network-operator/openshift-cluster-network-operator-release-4.22-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift/cluster-network-operator/openshift-cluster-network-operator-release-5.0-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (4)

• ci-operator/config/openshift/cluster-network-operator/openshift-cluster-network-operator-release-4.20.yaml
• ci-operator/config/openshift/cluster-network-operator/openshift-cluster-network-operator-release-4.21.yaml
• ci-operator/config/openshift/cluster-network-operator/openshift-cluster-network-operator-release-4.22.yaml
• ci-operator/config/openshift/cluster-network-operator/openshift-cluster-network-operator-release-5.0.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

Walkthrough

The release 4.20 through 5.0 CI configurations add optional intranet-capable bare-metal end-to-end jobs for OVN secondary encapsulation. Each job uses targeted path filters, an Equinix metal profile, and the secondary-encapsulation workflow.

Changes

OVN secondary encapsulation CI

Layer / File(s)

Summary

Release configuration test jobs ci-operator/config/openshift/cluster-network-operator/openshift-cluster-network-operator-release-4.20.yaml, ci-operator/config/openshift/cluster-network-operator/openshift-cluster-network-operator-release-4.21.yaml, ci-operator/config/openshift/cluster-network-operator/openshift-cluster-network-operator-release-4.22.yaml, ci-operator/config/openshift/cluster-network-operator/openshift-cluster-network-operator-release-5.0.yaml

Each release configuration adds or updates an optional intranet-capable bare-metal end-to-end job. The job uses targeted OVN-related path filters, an Equinix metal cluster profile, and the cluster-network-operator-ovn-secondary-encap workflow.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to dee13

This change adds release-branch CI coverage for OVN encapsulation overrides. No actionable merge-blocking risk remains after the normal configuration and job-generation checks.

Suggested reviewers: jmguzik

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
No-Sensitive-Data-In-Logs	❌ Error	New public presubmit jobs target the secondary-encap workflow, whose steps echo node and pod names and dump network configuration into CI logs.	Redact node and pod identifiers and avoid dumping ConfigMap or OVS output; log only sanitized validation results.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the addition of CNO secondary encapsulation CI lanes for releases 4.20 through 4.22 and 5.0.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR diff adds only static CI YAML job/workflow names and Prow metadata; it introduces no Ginkgo It(), Describe(), Context(), or When() test titles.
Test Structure And Quality	✅ Passed	The HEAD diff changes only eight CI YAML files; no source files or Ginkgo constructs were added, so the Ginkgo quality requirements are not applicable.
Microshift Test Compatibility	✅ Passed	The commit changes only eight YAML CI configuration files; the patch adds no Ginkgo test declarations or MicroShift-incompatible API references.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit changes only YAML CI configurations and job wiring; it adds no Ginkgo test code or new SNO-relevant cluster assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR changes only CI test configuration and generated Prow presubmit files; the diff adds no deployment, operator, controller, or topology scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The pull request changes only CI YAML declarations; it adds no OTE binary process-level stdout writes covered by this check.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff changes only CI configuration and generated job YAML; it adds no Ginkgo test declarations or test source, so this compatibility check is inapplicable.
No-Weak-Crypto	✅ Passed	The PR adds CI YAML and generated presubmit jobs only; added lines contain no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	The diff adds CI job and generated Prow pod definitions only; no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation fields are introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@cgoncalves: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-cluster-network-operator-release-4.20-e2e-metal-ipi-ovn-secondary-encap	openshift/cluster-network-operator	presubmit	Presubmit changed
pull-ci-openshift-cluster-network-operator-release-4.21-e2e-metal-ipi-ovn-secondary-encap	openshift/cluster-network-operator	presubmit	Presubmit changed
pull-ci-openshift-cluster-network-operator-release-4.22-e2e-metal-ipi-ovn-secondary-encap	openshift/cluster-network-operator	presubmit	Presubmit changed
pull-ci-openshift-cluster-network-operator-release-5.0-e2e-metal-ipi-ovn-secondary-encap	openshift/cluster-network-operator	presubmit	Presubmit changed
pull-ci-openshift-cluster-network-operator-release-5.0-e2e-aws-ovn-fdp-qe	openshift/cluster-network-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-network-operator-release-4.22-e2e-aws-ovn-fdp-qe	openshift/cluster-network-operator	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@cgoncalves: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[SchSeba]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cgoncalves, SchSeba
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/cluster-network-operator/OWNERS
• ci-operator/jobs/openshift/cluster-network-operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cgoncalves]

/pj-rehearse skip

We can't test CI until the 5.0 backport PR (openshift/cluster-network-operator#3124) and 4.x backport PRs merge first.

[openshift-merge-bot]

@cgoncalves: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[cgoncalves]

/pj-rehearse ack

[openshift-merge-bot]

@cgoncalves: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.