Skip to content

DPF: Enable daily runs - #83805

Open
josecastillolema wants to merge 1 commit into
openshift:mainfrom
josecastillolema:dpf-daily
Open

DPF: Enable daily runs#83805
josecastillolema wants to merge 1 commit into
openshift:mainfrom
josecastillolema:dpf-daily

Conversation

@josecastillolema

@josecastillolema josecastillolema commented Aug 21, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Enables a daily DPF network test run at 00:30 UTC using the metal-dpf-doca4 profile.
  • The new job deploys a cluster, loads its kubeconfig, runs hypervisor sanity checks, and executes network tests with a six-hour timeout.
  • Adds dpf-hypervisor-sanity-existing to the DOCA4, DOCA8, and DPF hypervisor deployment and network test workflows.

Signed-off-by: Jose Castillo Lema <josecastillolema@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: e0952478-0e81-4251-b1ac-61dbd84da621

📥 Commits

Reviewing files that changed from the base of the PR and between 02c07bd and df6fdd8.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/rh-ecosystem-edge/openshift-dpf/rh-ecosystem-edge-openshift-dpf-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (3)
  • ci-operator/config/rh-ecosystem-edge/openshift-dpf/rh-ecosystem-edge-openshift-dpf-main.yaml
  • ci-operator/config/rh-ecosystem-edge/openshift-dpf/rh-ecosystem-edge-openshift-dpf-main__nightly-4.22.yaml
  • ci-operator/config/rh-ecosystem-edge/openshift-dpf/rh-ecosystem-edge-openshift-dpf-release-4.22.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The DPF CI configurations add existing-cluster sanity checks to deployment and network test jobs. The main configuration also adds a daily DOCA4 network test job with deployment, kubeconfig loading, sanity checks, network tests, status reporting, and a six-hour timeout.

Changes

DPF network test coverage

Layer / File(s) Summary
Existing-cluster sanity checks
ci-operator/config/rh-ecosystem-edge/openshift-dpf/*
DOCA4 and DOCA8 deployment and network test jobs now run dpf-hypervisor-sanity-existing at the defined execution points.
Daily DOCA4 network test job
ci-operator/config/rh-ecosystem-edge/openshift-dpf/rh-ecosystem-edge-openshift-dpf-main.yaml
The main configuration adds daily-network-doca4, scheduled daily at 00:30 UTC, with cluster deployment, kubeconfig loading, sanity checks, network tests, status reporting, intranet access, and a six-hour timeout.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to df6fd

This change enables daily CI runs and adds synchronized generated job configuration. No actionable merge-blocking risk remains beyond normal verification that required deployment inputs are available.

Suggested reviewers: omertuc


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
No-Sensitive-Data-In-Logs ❌ Error The PR activates the sanity step in 11 new job paths; its command prints the remote .env, env, and full sanity log, which may expose Vault credentials in CI logs. Remove full .env/env/log output or redact sensitive values. Log only safe test summaries, and rotate credentials if logs already contain them.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the primary change: enabling daily DPF test runs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The diff only adds static CI job/step references and scheduling YAML; it adds no Ginkgo title calls, and the referenced sanity step was pre-existing and unchanged.
Test Structure And Quality ✅ Passed The PR changes only YAML job/config files and adds references to an existing shell step; no Ginkgo test code or It/BeforeEach/Eventually logic is added or modified.
Microshift Test Compatibility ✅ Passed The PR changes only CI YAML and adds an existing shell step; no new Ginkgo tests or MicroShift-targeted jobs were introduced. The step and its oc get co command predate the PR.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit adds only CI YAML/job wiring and references an existing shell-based sanity step; it adds no Ginkgo tests or topology-sensitive test declarations.
Topology-Aware Scheduling Compatibility ✅ Passed The diff changes only ci-operator YAML and a generated Prow periodic job; it adds no deployment manifests, operator code, controllers, or topology scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The commit changes only four YAML/Prow configuration files; the diff adds no OTE source, process-level setup, or stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only YAML CI/job configuration. The diff adds no Ginkgo test declarations or test implementation, so this check is not applicable.
No-Weak-Crypto ✅ Passed The commit adds CI YAML and references an unchanged sanity step; added lines contain no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed The PR diff adds CI schedules and test-step references only; no changed container/Kubernetes manifest contains privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2026
@openshift-ci
openshift-ci Bot requested review from szigmon and tsorya August 21, 2026 11:21
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@josecastillolema: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.
The following jobs are not rehearsable without the network-access-rehearsals-ok, and approved labels present on this PR. This is due to the restrict_network_access field being set to false. The network-access-rehearsals-ok label can be added by any openshift org member other than the PR's author by commenting: /pj-rehearse network-access-allowed:

Test name
pull-ci-rh-ecosystem-edge-openshift-dpf-main-deploy-cluster
pull-ci-rh-ecosystem-edge-openshift-dpf-main-network-tests
pull-ci-rh-ecosystem-edge-openshift-dpf-main-deploy-cluster-doca4
pull-ci-rh-ecosystem-edge-openshift-dpf-main-network-tests-doca4
periodic-ci-rh-ecosystem-edge-openshift-dpf-main-daily-network-doca4
pull-ci-rh-ecosystem-edge-openshift-dpf-main-nightly-4.22-deploy-cluster
pull-ci-rh-ecosystem-edge-openshift-dpf-main-nightly-4.22-deploy-cluster-doca4
pull-ci-rh-ecosystem-edge-openshift-dpf-release-4.22-deploy-cluster-doca4
pull-ci-rh-ecosystem-edge-openshift-dpf-release-4.22-network-tests
pull-ci-rh-ecosystem-edge-openshift-dpf-release-4.22-network-tests-doca4
pull-ci-rh-ecosystem-edge-openshift-dpf-release-4.22-deploy-cluster

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 21, 2026
@josecastillolema

Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@josecastillolema: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@josecastillolema: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eelgaev

eelgaev commented Aug 21, 2026

Copy link
Copy Markdown

/lgtm

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@eelgaev: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eelgaev, josecastillolema

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants