Skip to content

add kserve/llmisvc/storage-initializer image for e2e-kserve-module - #83847

Open
Jooho wants to merge 1 commit into
openshift:mainfrom
Jooho:add-km-image-0.17
Open

add kserve/llmisvc/storage-initializer image for e2e-kserve-module#83847
Jooho wants to merge 1 commit into
openshift:mainfrom
Jooho:add-km-image-0.17

Conversation

@Jooho

@Jooho Jooho commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Currently module opeator e2e test does not use the built image by ci . So I added them.

Summary by CodeRabbit

The OpenShift CI configuration now includes the kserve/llmisvc/storage-initializer image for e2e-kserve-module tests. These tests can use the storage initializer image built by CI.

Signed-off-by: Jooho Lee <ljhiyh@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a5b875c1-9211-49f2-bc7c-e4efb201b587

📥 Commits

Reviewing files that changed from the base of the PR and between 8bfd10f and cfd81eb.

📒 Files selected for processing (1)
  • ci-operator/config/opendatahub-io/kserve/opendatahub-io-kserve-release-v0.17.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The release configuration adds KServe controller, LLM inference service controller, and storage initializer image dependencies to the e2e-kserve-module test.

Changes

KServe E2E wiring

Layer / File(s) Summary
Declare E2E image dependencies
ci-operator/config/opendatahub-io/kserve/opendatahub-io-kserve-release-v0.17.yaml
The e2e-kserve-module test wiring now includes three additional image dependencies.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to cfd81

This localized CI configuration change adds the requested images and has no actionable merge-blocking risk beyond the normal requirement to regenerate and verify generated files.

Suggested reviewers: jlost

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the addition of the KServe, LLM inference service, and storage initializer images for e2e-kserve-module tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only CI image dependencies in the e2e-kserve-module job; it adds no Ginkgo test titles or dynamic test-name content.
Test Structure And Quality ✅ Passed The pull request changes only CI YAML image dependencies. It adds no Ginkgo test code, so the listed test-structure requirements are not applicable.
Microshift Test Compatibility ✅ Passed The PR changes only CI YAML image dependencies; it adds no Ginkgo tests, OpenShift API references, namespaces, or MicroShift-unsupported assumptions.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only CI image dependency declarations in a YAML file; it adds no Ginkgo tests or multi-node/HA assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The commit changes only CI test image dependencies; it adds no deployment, operator, controller, or scheduling constraints covered by this check.
Ote Binary Stdout Contract ✅ Passed The commit changes only CI YAML by adding three image dependencies; it adds no OTE binary code or process-level stdout/logging writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request changes only CI YAML. It adds image dependencies to an existing e2e-kserve-module job and adds no Ginkgo test declarations or test source files.
No-Weak-Crypto ✅ Passed The PR adds only three CI image dependency mappings to the e2e-kserve-module test; the added lines contain no weak-crypto algorithms, modes, or secret comparisons.
Container-Privileges ✅ Passed The commit adds only three CI image dependencies to e2e-kserve-module. It adds no privileged, host namespace, SYS_ADMIN, escalation, or root-running manifest fields.
No-Sensitive-Data-In-Logs ✅ Passed The commit only adds three CI image dependencies to the e2e test; it adds no logging or sensitive values, and the changed file passes git diff validation.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jooho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
openshift-ci Bot requested review from andresllh and spolti August 22, 2026 00:30
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2026
@Jooho

Jooho commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

/rehea/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Jooho: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-kserve-release-v0.17-e2e-kserve-module opendatahub-io/kserve presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

@Jooho: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Jooho

Jooho commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Jooho: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant