Add dedicated RELATED_IMAGE for instanceha instead of reusing openstackclient

[4383]

Instanceha pods were using OpenstackClientImage, which prevented OLM from independently overriding the instanceha container image for RHOSO deployments. This adds a dedicated RELATED_IMAGE_INSTANCE_HA_IMAGE_URL_DEFAULT env var and InstanceHaImage field so instanceha can be configured separately.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 4383
Once this PR has been reviewed and has the lgtm label, please assign fultonj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @4383. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[github-actions]

OpenStackControlPlane CRD Size Report

Metric	Value
CRD JSON size	364858 bytes (356KB)
Base branch size	364822 bytes
Change	+0.01%
Status	yellow — growing

Threshold reference

Color	Range	Meaning
🟢 green	< 300KB	Comfortable
🟡 yellow	300–400KB	Growing
🟠 orange	400–750KB	Concerning
🔴 red	> 750KB	Approaching 1.5MB etcd limit (cut in half to allow space for update)

[lmiccini]

Thanks Herve, we had this before and we decided to avoid adding a new constant/field/etc since we are sharing the same image as the openstackclient. We can fix this in infra-operator by flipping the logic around, so spec -> configmap -> webhook defaulting instead of what we have now openstack-k8s-operators/infra-operator#634

[4383]

@lmiccini no problem, thank you, then I'm closing this PR