Apply fix from https://github.com/SomeoneElseOSM/mod_tile/commit/de39d73820b28664295da2d80c788e76543f1fc7#500
Open
hummeltech wants to merge 1 commit into
Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #500 +/- ##
==========================================
- Coverage 81.54% 80.95% -0.60%
==========================================
Files 24 24
Lines 5645 5260 -385
==========================================
- Hits 4603 4258 -345
+ Misses 1042 1002 -40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
openstreetmap#494 The code "touchCalendar.tm_year > 105" assumed that tiles after 2005 could not have been marked dirty already. This was true when mod_tile was written but has not been true since 2025. Tiles in this branch and the master branch are dirtied by 20 years. This is relevant if somone uses "time since dirtying" as a metric for deletion, as happens e.g. at https://github.com/SomeoneElseOSM/database_qa_scripts/blob/main/purge_old_tiles.sh#L43 I've changed the test from 105 (== 2005) to 115 (== 2015) which will continue working until 2035 or so. I'd expect the upstream issue to be fixed by then. The oldest non-dirty tile in the "zoom" format (created by one of my branches of the code "zoom", "zoom2022" or "zoom2025" is 2016, which is when the code was first written. The metatile path is incompatible with other branches, so there cannot be older tiles.
hummeltech
force-pushed
the
TwiceDirtyTiles
branch
from
July 25, 2026 14:53
9728118 to
38dc327
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #494