Repository navigation
chore(ci): run CI on Python 3.15 - #644
Merged
Merged
Conversation
Pin every setup-uv/setup-python step to 3.15, and relock so each compiled dependency has a cp315 wheel: - pydantic 2.14.1 / pydantic-core 2.50.1 (xtest, otdf-local, otdf-sdk-mgr) - markupsafe 3.0.4 (xtest) requires-python stays >=3.14; this changes what CI runs, not the floor. Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 33 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
pflynn-virtru
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #640, which pinned `scriptcheck` to 3.14 after the CPython 3.15.0 release broke it.
Why it broke
The CI Python version wasn't pinned (`requires-python` is just `>=3.14`), so uv picked up 3.15 as soon as it shipped. markupsafe 3.0.3 had no cp315 wheel, so `uv sync` built it from source. The `uv run --frozen --no-build` step then refused to install it.
Changes
`requires-python` stays at `>=3.14`. This changes what CI runs, not the minimum for local development.
Verification
Locally on CPython 3.15.0, I ran the same steps as `scriptcheck` against fresh environments:
A scan of all three lock files found no compiled package without a cp315 or abi3 wheel. On this PR, the X-Test
xctmatrix (go, java, js; platformmainand v0.28.0) passes on 3.15. Thebenchandzip64jobs are opt-in and were skipped, so theirsetup-uvpins have not run yet.